Skip to content

docs: fix nginx config mount path in DEPLOYMENT_DOCKER.md SSL example #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrerfneves wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

docs: fix nginx config mount path in DEPLOYMENT_DOCKER.md SSL example #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPLOYMENT_DOCKER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ services:
- "80:80"
- "443:443"
volumes:
- ./nginx.conf:/etc/nginx/nginx.conf
- ./nginx.conf:/etc/nginx/conf.d/default.conf

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mount a proxy/TLS config instead

In this SSL/TLS Compose example, this line now loads the repo’s app-serving nginx.conf into the separate nginx:alpine reverse-proxy container. That config only listens on port 80 and serves /usr/share/nginx/html locally, with no proxy_pass to the lightning-decoder service and no listen 443 ssl, so following this production example still will not terminate TLS or route traffic to the app despite mapping 443 and declaring depends_on. The mounted file here needs to be an actual TLS reverse-proxy config rather than the Dockerfile’s static-site config.

Useful? React with 👍 / 👎.

- ./ssl:/etc/nginx/ssl
depends_on:
- lightning-decoder
Expand Down
Loading