Skip to content

chore: add .node-version file and engines field to package.json #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrerfneves wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add .node-version file and engines field to package.json #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
},
"license": "MIT",
"type": "module",
"engines": {
"node": ">=18"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require the same Node version as the locked tooling

This now advertises Node 18 as supported, but the checked-in lockfile already installs dev tools that do not support Node 18: package-lock.json records vitest@4.1.0 with node: ^20.0.0 || ^22.0.0 || >=24.0.0 and jsdom@29.1.1 with node: ^20.19.0 || ^22.13.0 || >=24.0.0. In environments that select or validate Node from package.json instead of .node-version, npm test/jsdom-based tests can run under Node 18 even though the installed test stack declares it unsupported; the engine range should be tightened to the minimum version the locked toolchain supports.

Useful? React with 👍 / 👎.

},
"dependencies": {
"@fontsource/geist-mono": "^5.2.8",
"@radix-ui/react-accordion": "^1.2.12",
Expand Down
Loading