refactor(ui): remove unused SheetPortal and SheetOverlay exports#200
Open
andrerfneves wants to merge 1 commit into
Open
refactor(ui): remove unused SheetPortal and SheetOverlay exports#200andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
These components are defined and used internally by SheetContent but are exported even though no external code imports them. Keeping the internal definitions as they are used by SheetContent; only removing them from the export block. Analogous to the DialogFooter removal in PR #179.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused
SheetPortalandSheetOverlayexports from the Sheet component. These components are defined and used internally bySheetContent, but no external code imports them, so they don't need to be part of the public export block.Why
Changes
src/components/ui/sheet.tsx: RemovedSheetPortalandSheetOverlayfrom theexport { ... }block. The component definitions remain in the file (they are used internally bySheetContent).Test Plan