refactor(ui): remove unused DropdownMenu subcomponent exports#201
Open
andrerfneves wants to merge 1 commit into
Open
refactor(ui): remove unused DropdownMenu subcomponent exports#201andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
Removes 9 unused subcomponents that are defined and exported but never imported by any code in the project: - DropdownMenuGroup, DropdownMenuPortal, DropdownMenuSub, DropdownMenuRadioGroup (simple aliases) - DropdownMenuSubTrigger, DropdownMenuSubContent (nested menu) - DropdownMenuCheckboxItem, DropdownMenuRadioItem (form items) - DropdownMenuShortcut (keyboard shortcut display) Also removes the now-unused Check, ChevronRight, and Circle icon imports from lucide-react. Follows the same pattern as PR #179 (DialogFooter removal) and PR #200 (SheetPortal/SheetOverlay export cleanup).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 9 unused subcomponent exports from the DropdownMenu component. These subcomponents are defined and exported but never imported by any code in the project.
Removed subcomponents
DropdownMenuGroupDropdownMenuPortalDropdownMenuPrimitive.Portaldirectly)DropdownMenuSubDropdownMenuRadioGroupDropdownMenuSubTriggerDropdownMenuSubContentDropdownMenuCheckboxItemDropdownMenuRadioItemDropdownMenuShortcutAlso removes the now-unused
Check,ChevronRight, andCircleicon imports fromlucide-react.Why
Changes
src/components/ui/dropdown-menu.tsx: Removed 9 unused subcomponent definitions and their export entries; cleaned up unused lucide-react icon importsTest Plan