chore: remove unused DialogClose and DialogTrigger exports from dialog component#203
Open
andrerfneves wants to merge 1 commit into
Open
chore: remove unused DialogClose and DialogTrigger exports from dialog component#203andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
…g component Both DialogClose and DialogTrigger were defined as aliases to @radix-ui/react-dialog primitives but never used internally or imported by any other file in the codebase. DialogContent uses DialogPrimitive.Close directly rather than the DialogClose alias. This complements PR #179 which removes the similarly unused DialogFooter export.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two unused exports from the
dialog.tsxshadcn/ui component:DialogClose— defined asDialogPrimitive.Closebut never used internally or imported elsewhere. The close button inDialogContentusesDialogPrimitive.Closedirectly.DialogTrigger— defined asDialogPrimitive.Triggerbut never used internally or imported elsewhere.This complements PR #179 which removes the similarly unused
DialogFooterexport.Verification
npm test— 52/52 tests passnpm run build— builds successfullyDialogCloseorDialogTriggerfrom anywhere in the codebase