docs(deployment): fix HEALTHCHECK example to install curl in Dockerfile#205
Open
andrerfneves wants to merge 1 commit into
Open
docs(deployment): fix HEALTHCHECK example to install curl in Dockerfile#205andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
The HEALTHCHECK example used curl to probe the container, but the base nginx:alpine image does not include curl by default. Added a RUN command to install curl before the HEALTHCHECK, preventing failures when users follow the example verbatim.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the HEALTHCHECK example in
DEPLOYMENT_DOCKER.mdto include installingcurlin the Dockerfile.Why
The base
nginx:alpineimage used in the production Docker stage does not includecurlby default. The HEALTHCHECK example showed:A developer adding this to their Dockerfile verbatim would see HEALTHCHECK failures because
curlis not available in the runtime container.Changes
DEPLOYMENT_DOCKER.md: AddedRUN apk add --no-cache curlbefore the HEALTHCHECK instruction in the Dockerfile exampleTest Plan