chore: remove unused DialogPortal and DialogOverlay exports from dialog component#207
Open
andrerfneves wants to merge 1 commit into
Open
Conversation
…og component DialogPortal and DialogOverlay are defined and used internally by DialogContent, but no consumer code imports them. This follows the same cleanup pattern as PR #200 for sheet.tsx (SheetPortal/SheetOverlay). Changes: - Removed DialogPortal and DialogOverlay from the export block in src/components/ui/dialog.tsx. The component definitions remain in the file since they are used internally by DialogContent. Verification: - No files import DialogPortal or DialogOverlay from anywhere - All 52 existing tests pass - Production build succeeds
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two unused exports (
DialogPortalandDialogOverlay) from the dialog shadcn/ui component. These components are defined and used internally byDialogContent, but no external code imports them, so they don't need to be part of the public export block.Why
Changes
src/components/ui/dialog.tsx: RemovedDialogPortalandDialogOverlayfrom theexport { ... }block. The component definitions remain in the file (they are used internally byDialogContent).Verification
DialogPortalorDialogOverlayfrom anywhere in the codebase