fix: update datetime usage to use UTC for consistency in library updater (#4392)

Author: andrew-codechimp

custom_components/battery_notes/library_updater.py

@@ -20,6 +20,7 @@
 from homeassistant.helpers.aiohttp_client import async_get_clientsession
 from homeassistant.helpers.event import async_track_utc_time_change
 from homeassistant.helpers.storage import STORAGE_DIR
+from homeassistant.util import dt as dt_util
 
 from .const import (
     DEFAULT_LIBRARY_URL,
@@ -62,14 +63,13 @@ def __init__(self, hass: HomeAssistant):
         self._client = LibraryUpdaterClient(session=async_get_clientsession(hass))
 
         # Fire the library check every 24 hours from just before now
-        refresh_time = datetime.now() - timedelta(hours=0, minutes=1)
+        refresh_time = dt_util.utcnow() - timedelta(hours=0, minutes=1)
         async_track_utc_time_change(
             hass,
             self.timer_update,
             hour=refresh_time.hour,
             minute=refresh_time.minute,
             second=refresh_time.second,
-            local=True,
         )
 
     @callback
@@ -132,7 +132,7 @@ def _update_library_json(library_file: str, content: str) -> None:
 
             domain_config = self.hass.data.get(MY_KEY)
             if domain_config:
-                self.hass.data[MY_KEY].library_last_update = datetime.now()
+                self.hass.data[MY_KEY].library_last_update = dt_util.utcnow()
 
             _LOGGER.debug("Updated library")
         else:
@@ -160,7 +160,7 @@ async def time_to_update_library(self, hours: int) -> bool:
                 return True
 
             if library_last_update := self.hass.data[MY_KEY].library_last_update:
-                time_since_last_update = datetime.now() - library_last_update
+                time_since_last_update = dt_util.utcnow() - library_last_update
 
                 time_difference_in_hours = time_since_last_update / timedelta(hours=1)
 

pyproject.toml

@@ -89,6 +89,8 @@ ignore = [
 
   # Project preference
   "ERA001",  # Found commented-out code
+  "FBT001",  # Boolean-typed positional argument in function definition
+  "FBT002",  # Boolean-typed positional argument in function definition
   "RUF001", # String contains ambiguous character
   "S101",   # Use of assert detected
   "TC001",  # Move application import into type checking
@@ -101,11 +103,8 @@ ignore = [
   "ANN201",  # Missing return type annotation for public function
   "ANN202",  # Missing return type annotation for private function
   "ANN204",  # Missing return type annotation for special method
-  "DTZ005",  # The use of `datetime.datetime.now()` without `tz` argument is not allowed
   "EM101",   # Exception must not use a string literal, assign to variable first
   "EM102",   # Exception must not use an f-string literal, assign to variable first
-  "FBT001",  # Boolean-typed positional argument in function definition
-  "FBT002",  # Boolean-typed positional argument in function definition
   "PLR2004", # Magic value used in comparison
   "PTH103",  # `os.makedirs()` should be replaced by `Path.mkdir()`
   "PTH104",  # `os.rename()` should be replaced by `Path.rename()`