Library workflow refactor#3928
Conversation
|
Hi, I'll have a full read through the changes but to answer your questions new_device.yaml is working, it throws a deprecation warning at the moment, but it's been doing this for years and following the GitHub discussion they're not ready to remove it yet as it's used in many workflows The output is used in the Create Pull Request step The run-python-script-action provides the utility functions, I do see there is a set env method now which we should maybe move to. release.yaml there's an option set within HACS to use the zip file, this gives the advantage of providing download counts for the latest version. |
…ssentials included in the image.
…dd the packages required for the actions being taken via dependency groups, while maintaining default uv sync behavior
all makes sense. I can play with refactoring the run-python-script-action at some point, and good deal on release.yaml. for now I think** this PR is good to go, but maybe do some additional testing on your end |
|
I had to rename the issue templates to be .yaml, there was a reference elsewhere to it. |
Oh sorry I didn't clarify, check the library python file, I moved the sorting into a function of that file to let it handle both actions rather than have the python in the yaml |
|
I'm not seeing that in the library file, did you miss a commit? |
|
Ohhh yea I see what happened. I have a commit to reapply still. Good catch!! |
check now :) |
|
All looks good, gave it a quick check on the BN-Test repo for the issue form/action Thanks for all the work on this, it's got it a lot cleaner. |
closes #3906
@andrew-codechimp
Ended up reviewing and/or refactoring all workflows.
switched the ones that will need UV to use a uv based container image.
only workflow I didn't refactor for UV was new_device.yaml.. is that one even working? when I tried to drop the python into a .py file it complained that "set_output" wasn't defined.
also, can we delete release.yaml? kinda confused why its uploading a zip to the release when the release autogenerates a zip of the project at that commit already.