Add device: Zbeacon - TH01#4649
Merged
Merged
Conversation
Contributor
|
Okay, these cheap "Zbeacon" devices seem rather problematic for battery notes. I wanted to add another task for another device, it is also:
but uses a CR2032 battery. Not sure whether it makes sense to really add this one, particularly as I noticed that library/library.json already has a similar entry (which is slightly different). |
Owner
|
Hi, yeah if they don't differentiate the model, model ID or hardware version then I'd usually put these in the library as MANUAL to make sure they don't keep getting suggested updates. |
Changed battery type from 'AAA' to 'MANUAL' for Zbeacon TH01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the device information for:
Manufacturer: Zbeacon
Model: TH01
Model ID:
Hardware:
Battery: 2x AAA
It closes issue #4648
If Battery Notes is useful to you please
