Skip to content

Commit 3f7dadd

Browse files
cortinicofacebook-github-bot
authored andcommitted
Always quote the user + add links to the release support policy (facebook#43810)
Summary: Pull Request resolved: facebook#43810 This bot never works because facebook bot is faster. I'm updating the logic to always publish the thank you message + update the link with the correct one. Changelog: [Internal] [Changed] - Always quote the user + add links to the release support policy Reviewed By: rshest, cipolleschi Differential Revision: D55643675 fbshipit-source-id: d2e726580c82d7f89b37d17846675b7c4c38e908
1 parent 1561cc9 commit 3f7dadd

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/close_pr.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@ jobs:
4242
repo: context.repo.repo,
4343
})).data;
4444
45-
// If the PR has already been processed (labeled as Merged), skip it
46-
const mergedLabel = "Merged";
47-
if(pr.labels && pr.labels.some(label => label.name === mergedLabel)) return;
48-
4945
const authorName = author?.login ? `@${author.login}` : commit.author.name;
5046
5147
github.rest.issues.createComment({
5248
issue_number: closedPrNumber,
5349
owner: context.repo.owner,
5450
repo: context.repo.repo,
55-
body: `This pull request was successfully merged by ${authorName} in **${sha}**.\n\n<sup>[When will my fix make it into a release?](https://github.com/facebook/react-native/wiki/Release-FAQ#when-will-my-fix-make-it-into-a-release) | [Upcoming Releases](https://github.com/reactwg/react-native-releases/discussions/categories/releases)</sup>`
51+
body: `This pull request was successfully merged by ${authorName} in **${sha}**.\n\n<sup>[When will my fix make it into a release?](https://github.com/reactwg/react-native-releases/blob/main/docs/faq.md#when-will-my-fix-make-it-into-a-release) | [How to file a pick request?](https://github.com/reactwg/react-native-releases/blob/main/docs/faq.md#how-to-open-a-pick-request)</sup>`
5652
});
5753
54+
// If the PR has already been processed (labeled as Merged), skip it
55+
const mergedLabel = "Merged";
56+
if(pr.labels && pr.labels.some(label => label.name === mergedLabel)) return;
57+
5858
github.rest.issues.addLabels({
5959
issue_number: closedPrNumber,
6060
owner: context.repo.owner,

0 commit comments

Comments
 (0)