Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

Updating gracefull-fs.#230

Open
petermilan wants to merge 2 commits into
andrewrk:masterfrom
BrandedEntertainmentNetwork:node-12
Open

Updating gracefull-fs.#230
petermilan wants to merge 2 commits into
andrewrk:masterfrom
BrandedEntertainmentNetwork:node-12

Conversation

@petermilan

@petermilan petermilan commented Jan 17, 2020

Copy link
Copy Markdown

To be able to run node-s3-client on node v12 we need to update gracefull-fs package.

@Dectom

Dectom commented Jun 21, 2020

Copy link
Copy Markdown

This needs to be fixed, Please accept this

@Jaygiri

Jaygiri commented Jul 23, 2020

Copy link
Copy Markdown

We need this - please accept this PR.
@andrewrk @kacole2 @faceleg @maki10 @dvalentiate

@RobvH

RobvH commented Aug 10, 2020

Copy link
Copy Markdown

@andrewrk @kacole2 @faceleg @maki10 @dvalentiate It appears this simple update would significantly reduce problems we're having using the library. We've been on Node 12 for a while. Merging this update would be fantastic.

@deeheber

Copy link
Copy Markdown

^ bump this affects my company as well.

@gtzinos

gtzinos commented Sep 28, 2020

Copy link
Copy Markdown

Hi,

Any update on this? We all urgently need it, as the node 12 is a minimum requirement for our projects.

@Jaygiri

Jaygiri commented Sep 28, 2020

Copy link
Copy Markdown

While @andrewrk is busy creating zig try this if you are using yarn...

Add following to your package.json

"resolutions": {
    "node-s3-client/graceful-fs": "4.2.4"
  }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants