Skip to content

[client] support message cancellation#45

Merged
capcom6 merged 1 commit into
masterfrom
client/cancel-message
Jul 8, 2026
Merged

[client] support message cancellation#45
capcom6 merged 1 commit into
masterfrom
client/cancel-message

Conversation

@capcom6

@capcom6 capcom6 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added support for cancelling messages from both synchronous and asynchronous clients.
    • Introduced new cancellation-related status values so message lifecycle states can now reflect cancellation progress and completion.
    • Added a new cancellation webhook event for downstream integrations to react to cancelled messages.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d4dded6-5d02-4a63-8207-5773f0523b51

📥 Commits

Reviewing files that changed from the base of the PR and between 1640f96 and d997a18.

📒 Files selected for processing (2)
  • android_sms_gateway/client.py
  • android_sms_gateway/enums.py

📝 Walkthrough

Walkthrough

The PR adds message cancellation support to the sync and async clients, each issuing DELETE requests to /messages/{_id}. It also extends enums with cancellation process states and a new sms:cancelled webhook event.

Changes

Message cancellation support

Layer / File(s) Summary
Cancellation states and webhook event
android_sms_gateway/enums.py
ProcessState gains Cancelling and Cancelled, and WebhookEvent gains SMS_CANCELLED with its docstring text.
Sync and async cancel_message endpoints
android_sms_gateway/client.py
APIClient and AsyncAPIClient add cancel_message(_id) methods that validate the HTTP client and send DELETE /messages/{_id} with the existing headers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding client-side support for message cancellation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capcom6

capcom6 commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6

capcom6 commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6 capcom6 added the ready label Jun 26, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 7 days with no activity.

@github-actions github-actions Bot added the stale label Jul 3, 2026
@capcom6 capcom6 self-assigned this Jul 4, 2026
@capcom6 capcom6 removed the stale label Jul 4, 2026
@capcom6 capcom6 merged commit 1a986df into master Jul 8, 2026
10 checks passed
@capcom6 capcom6 deleted the client/cancel-message branch July 8, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant