Skip to content

Add flexbox sample#45

Merged
JonEckenrode merged 12 commits into
mainfrom
add-flexbox-sample
May 13, 2026
Merged

Add flexbox sample#45
JonEckenrode merged 12 commits into
mainfrom
add-flexbox-sample

Conversation

@JonEckenrode

@JonEckenrode JonEckenrode commented May 9, 2026

Copy link
Copy Markdown
Contributor

FlexBox sample for the adaptive apps development hub sample page.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Jetpack Compose sample application demonstrating the FlexBox API through various layout examples, including navigation and basic architectural components. Feedback focuses on improving consistency and code quality, such as utilizing the version catalog for dependencies, adopting data object for state-less sealed interface implementations, and removing unused imports or integrating the currently unused ViewModel. Additionally, suggestions were made to replace hardcoded colors with theme-aware values and to adjust the modifier order to ensure correct safe area padding behavior.

Comment thread FlexBox/app/build.gradle.kts Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/ui/main/MainScreen.kt Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/ui/main/MainScreen.kt Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/ui/main/MainScreen.kt Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/FlexBoxSample.kt Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/FlexBoxSample.kt Outdated
Comment thread FlexBox/app/src/main/java/com/example/flexboxsample/FlexBoxSample.kt Outdated
@JonEckenrode JonEckenrode merged commit 095c4b3 into main May 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants