Skip to content

Add Grid sample#46

Merged
JonEckenrode merged 11 commits into
mainfrom
add-grid-sample
May 13, 2026
Merged

Add Grid sample#46
JonEckenrode merged 11 commits into
mainfrom
add-grid-sample

Conversation

@JonEckenrode

@JonEckenrode JonEckenrode commented May 9, 2026

Copy link
Copy Markdown
Contributor

Add a Grid sample for the adaptive apps development hub samples page.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Android project named Grid that demonstrates a three-column layout using the experimental Compose Grid API, including the complete project structure and build configuration. Feedback focuses on correcting several futuristic or unsupported versions for the Android SDK, Gradle Plugin, Kotlin, and Compose BOM to ensure build stability. Additionally, suggestions were made to improve code consistency by utilizing the version catalog for all dependencies, adopting idiomatic Compose functions like luminance(), and refining modifier logic.

Comment thread Grid/app/build.gradle.kts
Comment thread Grid/gradle/libs.versions.toml
Comment thread Grid/gradle/libs.versions.toml Outdated
Comment thread Grid/gradle/libs.versions.toml
Comment thread Grid/app/build.gradle.kts Outdated
Comment thread Grid/app/build.gradle.kts Outdated
Comment thread Grid/app/src/main/java/com/example/gridsample/MainActivity.kt Outdated
Comment thread Grid/app/src/main/java/com/example/gridsample/MainActivity.kt Outdated
Comment thread Grid/app/src/main/java/com/example/gridsample/MainActivity.kt Outdated
Comment thread Grid/gradle/libs.versions.toml Outdated
@JonEckenrode JonEckenrode changed the title Add Grid layout sample application and update .gitignore Add Grid sample May 10, 2026
Comment thread Grid/app/src/main/java/com/example/gridsample/GridSample.kt
Comment thread Grid/app/src/main/java/com/example/gridsample/GridSample.kt Outdated
…ems to 5, unroll loop, and use Google colors with black accent
@JonEckenrode JonEckenrode merged commit 19f0d04 into main May 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants