Fixes: Build issues and updates dependencies#43
Merged
Conversation
Updates: Java versions to 11 to be compatible with java version generated by baseline profile and benchmark module
mlykotom
approved these changes
Jun 10, 2025
mlykotom
left a comment
mlykotom
left a comment
Contributor
There was a problem hiding this comment.
I have a question around profile installer dependency, otherwise lgtm
| implementation(libs.coil.kt.compose) | ||
|
|
||
| implementation(libs.androidx.runtime.tracing) | ||
| implementation(libs.androidx.profileinstaller) |
Contributor
There was a problem hiding this comment.
should we have this in the main branch? This should be added with the macrobench / baseline profile modules
Contributor
Author
There was a problem hiding this comment.
Yeah you are right. Removed the dependency in 628a128
| implementation(libs.coil.kt.compose) | ||
|
|
||
| implementation(libs.androidx.runtime.tracing) | ||
| implementation(libs.androidx.profileinstaller) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR