Maintanece updates#44
Closed
AjeshRPai wants to merge 32 commits into
Closed
Conversation
[bechmark][main] Downgrading AGP version to work with Flamingo
AGP, Gradle and library version updates
AGP, Gradle and library version updates
chore: Configure Renovate
Add CI actions
fix(deps): update all dependencies (main)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Replaces: unsplash image urls with static images Updates: composable to respect edge to edge displays
Baseline Profile Codelab Sample App - Replaces unsplash urls with static images
Key changes include: - Replacing `imageUrl` with `@DrawableRes imageRes` for local image loading, removing the dependency on network calls for images. - Updating `MainActivity` to use `enableEdgeToEdge()` for drawing behind system bars. - Replacing `WindowCompat.setDecorFitsSystemWindows(window, false)` with `enableEdgeToEdge()`. - Updating `JetsnackMain` to use `safeDrawingPadding()` and `consumeWindowInsets()` for proper handling of system insets. - Replacing deprecated Material 2 icons with Material 3 equivalents, including `Icons.AutoMirrored.Outlined.ArrowBack`. - Adding new drawable resources for local image loading.
Replaces: Unsplash image url with static images [Macro benchmark sample]
Updates: Java versions to 11 to be compatible with java version generated by baseline profile and benchmark module
Fixes: Build issues and updates dependencies
# Conflicts: # baseline-profiles/app/build.gradle.kts # baseline-profiles/build.gradle.kts # baseline-profiles/gradle/libs.versions.toml # benchmarking/app/build.gradle.kts # benchmarking/build.gradle.kts # benchmarking/gradle/libs.versions.toml
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across the codebase, focusing on dependency configuration, migration to drawable resources for images, and UI enhancements. The most significant changes include updating the Gradle configuration, replacing image URLs with drawable resources, and improving system bar handling and layout padding.
Dependency and Configuration Updates:
.github/renovate.jsonfile to configure Renovate with a local configuration and specified base branches (mainandend).baselineprofileand set Java and Kotlin compatibility options to version 11 inbaseline-profiles/app/build.gradle.kts. [1] [2] [3]androidx.profileinstallerinbaseline-profiles/app/build.gradle.kts.Migration to Drawable Resources:
imageUrlfields withimageRes(drawable resource IDs) in theSearchCategoryandSnackmodels, and updated corresponding usages inSearch.ktandSnack.kt. [1] [2] [3] [4] [5]SnackImage,CartItem,SnackItem, andHighlightSnackItem) to use drawable resources instead of URLs. [1] [2] [3] [4]UI Enhancements:
WindowCompat.setDecorFitsSystemWindowswithenableEdgeToEdgeinMainActivity.safeDrawingPaddingandconsumeWindowInsetstoJetsnackMain. [1] [2]Miscellaneous:
Icons.AutoMirrored.OutlinedinSnacks.kt.