Maintanence update#45
Merged
Merged
Conversation
Replaces: unsplash image urls with static images Updates: composable to respect edge to edge displays (cherry picked from commit 04557fb)
(cherry picked from commit 1ee15c2)
Key changes include: - Replacing `imageUrl` with `@DrawableRes imageRes` for local image loading, removing the dependency on network calls for images. - Updating `MainActivity` to use `enableEdgeToEdge()` for drawing behind system bars. - Replacing `WindowCompat.setDecorFitsSystemWindows(window, false)` with `enableEdgeToEdge()`. - Updating `JetsnackMain` to use `safeDrawingPadding()` and `consumeWindowInsets()` for proper handling of system insets. - Replacing deprecated Material 2 icons with Material 3 equivalents, including `Icons.AutoMirrored.Outlined.ArrowBack`. - Adding new drawable resources for local image loading. (cherry picked from commit 0251b98)
(cherry picked from commit d8d4527)
Updates: Java versions to 11 to be compatible with java version generated by baseline profile and benchmark module (cherry picked from commit bf44d74)
(cherry picked from commit 628a128)
mlykotom
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces multiple changes across the codebase, focusing on replacing URL-based image loading with drawable resources, updating dependencies and configurations, and improving UI behaviors. The most significant updates include transitioning from
imageUrltoimageResfor image handling, modifying Gradle configuration for compatibility, and enhancing UI components for better system integration.Image Handling Updates:
imageUrlwithimageResin theSearchCategoryandSnackmodels to use drawable resources instead of remote URLs. Updated all corresponding usages inSearch.kt,Snack.kt, and various UI components (Snacks.kt,Categories.kt,Cart.kt). [1] [2] [3] [4] [5]Gradle Configuration Changes:
baseline-profiles/app/build.gradle.ktsfile to change the plugin alias forbaselineprofileand set Java compatibility to version 11 instead of 17. [1] [2] [3]UI Enhancements:
consumeWindowInsetsandsafeDrawingPaddingfor better handling of system window insets inJetsnackMain.kt. [1] [2] [3]Icons.AutoMirrored.Outlinedfor RTL support inSnacks.kt. [1] [2]System Integration Improvements:
WindowCompat.setDecorFitsSystemWindowswithenableEdgeToEdgeinMainActivity.ktfor edge-to-edge UI handling.Minor Adjustments:
build.gradle.ktsand other files. [1] [2] Fcd9ab79L42R42)