Skip to content

Commit e576720

Browse files
carmenyhcopybara-github
authored andcommitted
What breaks if I do this?
PiperOrigin-RevId: 806235046
1 parent 6880dd2 commit e576720

2 files changed

Lines changed: 12 additions & 14 deletions

File tree

src/main/kotlin/testing/FakeCalendar.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import java.time.LocalDate
2121
import java.time.ZoneId
2222
import java.util.Date
2323

24-
class FakeCalendar(val today: LocalDate = LocalDate.of(2024, 10, 20)) {
24+
class FakeCalendar(val today: LocalDate = LocalDate.now()) {
2525
fun today(): Date = today.toDate()
2626

2727
fun now(): Instant = today.atStartOfDay(ZoneId.of("UTC")).toInstant()
@@ -30,6 +30,8 @@ class FakeCalendar(val today: LocalDate = LocalDate.of(2024, 10, 20)) {
3030

3131
fun tomorrow(): Date = today.plusDays(1).toDate()
3232

33+
fun nextYear(): Date = today.plusYears(1).toDate()
34+
3335
private fun Instant.toDate() = Date.from(this)
3436

3537
private fun LocalDate.toDate() = this.atStartOfDay(ZoneId.of("UTC")).toInstant().toDate()

src/test/kotlin/provider/KeyAttestationCertPathValidatorTest.kt

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -78,23 +78,19 @@ class KeyAttestationCertPathValidatorTest {
7878
}
7979

8080
@Test
81-
fun nullDate_throwsCertPathValidatorException() {
82-
val exception =
81+
fun nullDate_assumesNow() {
82+
val unused =
83+
certPathValidator.validate(Chains.validFactoryProvisioned, PKIXParameters(setOf(testAnchor)))
84+
val notValidException =
8385
assertFailsWith<CertPathValidatorException> {
84-
certPathValidator.validate(
85-
Chains.validFactoryProvisioned,
86-
PKIXParameters(setOf(testAnchor)),
87-
)
86+
certPathValidator.validate(Chains.notYetValid, PKIXParameters(setOf(testAnchor)))
8887
}
89-
val pkixException =
88+
val expiredException =
9089
assertFailsWith<CertPathValidatorException> {
91-
pkixCertPathValidator.validate(
92-
Chains.validFactoryProvisioned,
93-
PKIXParameters(setOf(testAnchor)),
94-
)
90+
certPathValidator.validate(Chains.expired, PKIXParameters(setOf(testAnchor)))
9591
}
96-
assertThat(exception.reason).isEqualTo(BasicReason.EXPIRED)
97-
assertThat(pkixException.reason).isEqualTo(BasicReason.EXPIRED)
92+
assertThat(notValidException.reason).isEqualTo(BasicReason.NOT_YET_VALID)
93+
assertThat(expiredException.reason).isEqualTo(BasicReason.EXPIRED)
9894
}
9995

10096
@Test

0 commit comments

Comments
 (0)