Skip to content

Commit d1c8777

Browse files
Final synchronization of Gradle configs and NDKHelper source
* Applied consistent minSdk and import formatting to teapots and native modules. * Cleaned up remaining Java source inconsistencies in NativeAudio and NDKHelper.
1 parent 568aa28 commit d1c8777

12 files changed

Lines changed: 30 additions & 33 deletions

File tree

native-audio/app/src/main/java/com/example/nativeaudio/NativeAudio.java

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
package com.example.nativeaudio;
1818

1919
import android.Manifest;
20-
import android.annotation.TargetApi;
2120
import android.app.Activity;
2221
import android.content.Context;
2322
import android.content.pm.PackageManager;
2423
import android.content.res.AssetManager;
2524
import android.media.AudioManager;
26-
import android.os.Build;
2725
import android.os.Bundle;
2826
import android.view.View;
2927
import android.view.View.OnClickListener;
@@ -60,7 +58,6 @@ public class NativeAudio extends Activity
6058

6159
/** Called when the activity is first created. */
6260
@Override
63-
@TargetApi(17)
6461
protected void onCreate(Bundle icicle) {
6562
super.onCreate(icicle);
6663
setContentView(R.layout.main);
@@ -78,14 +75,12 @@ protected void onCreate(Bundle icicle) {
7875
* IF we do not have a fast audio path, we pass 0 for sampleRate, which will force native
7976
* side to pick up the 8Khz sample rate.
8077
*/
81-
if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
82-
AudioManager myAudioMgr = (AudioManager) getSystemService(Context.AUDIO_SERVICE);
83-
String nativeParam = myAudioMgr.getProperty(AudioManager.PROPERTY_OUTPUT_SAMPLE_RATE);
84-
sampleRate = Integer.parseInt(nativeParam);
85-
nativeParam = myAudioMgr.getProperty(AudioManager.PROPERTY_OUTPUT_FRAMES_PER_BUFFER);
86-
bufSize = Integer.parseInt(nativeParam);
87-
}
88-
createBufferQueueAudioPlayer(sampleRate, bufSize);
78+
AudioManager myAudioMgr = (AudioManager) getSystemService(Context.AUDIO_SERVICE);
79+
String nativeParam = myAudioMgr.getProperty(AudioManager.PROPERTY_OUTPUT_SAMPLE_RATE);
80+
sampleRate = Integer.parseInt(nativeParam);
81+
nativeParam = myAudioMgr.getProperty(AudioManager.PROPERTY_OUTPUT_FRAMES_PER_BUFFER);
82+
bufSize = Integer.parseInt(nativeParam);
83+
createBufferQueueAudioPlayer(sampleRate, bufSize);
8984

9085
// initialize URI spinner
9186
Spinner uriSpinner = (Spinner) findViewById(R.id.uri_spinner);
@@ -275,19 +270,17 @@ public void onStopTrackingTouch(SeekBar seekBar) {
275270
setStereoPositionUriAudioPlayer(permille);
276271
}
277272
});
278-
if (Build.VERSION.SDK_INT > 19) {
279-
int[] uriIds = { R.id.uri_soundtrack, R.id.pause_uri,
280-
R.id.play_uri, R.id.loop_uri,
281-
R.id.mute_left_uri, R.id.mute_right_uri,
282-
R.id.solo_left_uri, R.id.solo_right_uri,
283-
R.id.mute_uri, R.id.enable_stereo_position_uri,
284-
R.id.channels_uri, R.id.volume_uri,
285-
R.id.pan_uri, R.id.uri_spinner,};
286-
for(int id : uriIds)
287-
findViewById(id).setEnabled(false);
288-
}
289-
290-
((Button) findViewById(R.id.record)).setOnClickListener(new OnClickListener() {
273+
int[] uriIds = {R.id.uri_soundtrack, R.id.pause_uri,
274+
R.id.play_uri, R.id.loop_uri,
275+
R.id.mute_left_uri, R.id.mute_right_uri,
276+
R.id.solo_left_uri, R.id.solo_right_uri,
277+
R.id.mute_uri, R.id.enable_stereo_position_uri,
278+
R.id.channels_uri, R.id.volume_uri,
279+
R.id.pan_uri, R.id.uri_spinner,};
280+
for(int id : uriIds)
281+
findViewById(id).setEnabled(false);
282+
283+
((Button) findViewById(R.id.record)).setOnClickListener(new OnClickListener() {
291284
public void onClick(View view) {
292285
int status = ActivityCompat.checkSelfPermission(NativeAudio.this,
293286
Manifest.permission.RECORD_AUDIO);
@@ -396,7 +389,7 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[] permis
396389
public static native void startRecording();
397390
public static native void shutdown();
398391

399-
/** Load jni .so on initialization */
392+
/* Load jni .so on initialization */
400393
static {
401394
System.loadLibrary("native-audio-jni");
402395
}

native-midi/app/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ android {
99
applicationId = "com.example.nativemidi"
1010
versionCode = 1
1111
versionName = "1.0"
12+
// 'AMidiOutputPort_receive' is unavailable: introduced in Android 29 android
13+
minSdk = 30
1214
externalNativeBuild {
1315
cmake {
1416
arguments.add("-DANDROID_STL=c++_static")

teapots/choreographer-30fps/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ android {
77

88
defaultConfig {
99
applicationId = "com.sample.choreographer"
10+
// 'AImageDecoder' is unavailable: introduced in Android 30 android
11+
minSdk = 30
1012
externalNativeBuild {
1113
cmake {
1214
arguments.add("-DANDROID_STL=c++_static")

teapots/choreographer-30fps/src/main/java/com/sample/helper/NDKHelper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ public String getStringResource(String resourceName)
309309
//
310310
// Audio related helpers
311311
//
312-
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
313312
public int getNativeAudioBufferSize() {
314313
int SDK_INT = android.os.Build.VERSION.SDK_INT;
315314
if (SDK_INT >= 17) {

teapots/classic-teapot/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ android {
77

88
defaultConfig {
99
applicationId = "com.sample.teapot"
10+
// 'AImageDecoder' is unavailable: introduced in Android 30 android
11+
minSdk = 30
1012
externalNativeBuild {
1113
cmake {
1214
arguments.add("-DANDROID_STL=c++_static")

teapots/classic-teapot/src/main/java/com/sample/helper/NDKHelper.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.sample.helper;
1818

19-
import android.annotation.TargetApi;
2019
import android.app.NativeActivity;
2120
import android.content.Context;
2221
import android.content.pm.ApplicationInfo;
@@ -28,14 +27,12 @@
2827
import android.media.AudioManager;
2928
import android.media.AudioTrack;
3029
import android.opengl.GLUtils;
31-
import android.os.Build;
3230
import android.util.Log;
3331
import java.io.File;
3432
import java.io.FileInputStream;
3533
import java.nio.ByteBuffer;
3634
import javax.microedition.khronos.opengles.GL10;
3735

38-
@TargetApi(Build.VERSION_CODES.GINGERBREAD)
3936
public class NDKHelper {
4037

4138
public NDKHelper(NativeActivity act) {
@@ -309,7 +306,6 @@ public String getStringResource(String resourceName)
309306
//
310307
// Audio related helpers
311308
//
312-
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
313309
public int getNativeAudioBufferSize() {
314310
int SDK_INT = android.os.Build.VERSION.SDK_INT;
315311
if (SDK_INT >= 17) {

teapots/image-decoder/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ android {
77

88
defaultConfig {
99
applicationId = "com.sample.imagedecoder"
10+
// 'AImageDecoder' is unavailable: introduced in Android 30 android
11+
minSdk = 30
1012
externalNativeBuild {
1113
cmake {
1214
arguments.add("-DANDROID_STL=c++_static")

teapots/image-decoder/src/main/java/com/sample/helper/NDKHelper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,6 @@ public String getStringResource(String resourceName)
307307
//
308308
// Audio related helpers
309309
//
310-
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
311310
public int getNativeAudioBufferSize() {
312311
int SDK_INT = android.os.Build.VERSION.SDK_INT;
313312
if (SDK_INT >= 17) {

teapots/more-teapots/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ android {
77

88
defaultConfig {
99
applicationId = "com.sample.moreteapots"
10+
// 'AImageDecoder' is unavailable: introduced in Android 30 android
11+
minSdk = 30
1012
externalNativeBuild {
1113
cmake {
1214
arguments.add("-DANDROID_STL=c++_static")

teapots/more-teapots/src/main/java/com/sample/helper/NDKHelper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ public String getStringResource(String resourceName)
309309
//
310310
// Audio related helpers
311311
//
312-
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
313312
public int getNativeAudioBufferSize() {
314313
int SDK_INT = android.os.Build.VERSION.SDK_INT;
315314
if (SDK_INT >= 17) {

0 commit comments

Comments
 (0)