Skip to content

build(build-logic): fix Spotless targets for Kotlin scripts #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkamanin wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

build(build-logic): fix Spotless targets for Kotlin scripts #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Spotless.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ internal fun Project.configureSpotlessForRootProject() {
endWithNewline()
}
format("kts") {
target("*.kts")
target("build-logic/*.kts")
target("build-logic/convention/*.kts")
target("*.kts", "build-logic/*.kts", "build-logic/convention/*.kts")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current list of target patterns is quite specific and may miss .kts files in newly added modules or deeper directories within build-logic. Using a recursive glob pattern like build-logic/**/*.kts would be more robust and maintainable, ensuring all script files within the build logic are covered regardless of future changes to the directory structure.

Suggested change
target("*.kts", "build-logic/*.kts", "build-logic/convention/*.kts")
target("*.kts", "build-logic/**/*.kts")

// Look for the first line that doesn't have a block comment (assumed to be the license)
licenseHeaderFile(rootDir.resolve("spotless/copyright.kts"), "(^(?![\\/ ]\\*).*$)")
endWithNewline()
Expand Down