Use RotatingFileHandler to prevent unbounded log file growth#58
Open
ContinualDissapointment wants to merge 1 commit intoandroidWG:mainfrom
Open
Use RotatingFileHandler to prevent unbounded log file growth#58ContinualDissapointment wants to merge 1 commit intoandroidWG:mainfrom
ContinualDissapointment wants to merge 1 commit intoandroidWG:mainfrom
Conversation
The current FileHandler allows log files to grow indefinitely, which can consume significant disk space (100+ GB observed in long-running sessions). This change switches to RotatingFileHandler with: - 5 MB max file size - 3 backup files retained This limits total log storage to ~20 MB per session while preserving recent logs for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
FileHandlerallows log files to grow indefinitely, which can consume significant disk space. I observed 150+ GB of log files after extended use.This change switches to
RotatingFileHandlerwith:This limits total log storage to ~20 MB per session while preserving recent logs for debugging.
Changes
src/util/log_setup.py: Replacelogging.FileHandlerwithlogging.handlers.RotatingFileHandlerTest plan
delete_old_logs()regex already handles rotated file naming