feat(lint): add UncheckedFlagAccess, ExpiredFeatureFlag, and InvalidFlagReference detectors#176
Merged
Merged
Conversation
Detects @BehindFlag/@AssumesFlag annotations whose flagName does not match any ConfigParam property in the same file. Skips files with no ConfigParam declarations to avoid false positives from generated code. Also fixes pre-existing compile errors in ExpiredFeatureFlagDetector and UncheckedFlagAccessDetector (ambiguous overload, missing uastContents API) and adds their test files that were present but never committed.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Detects ConfigParam properties annotated with @ExpiresAt where the date has passed. Rewrites the previous broken implementation to use getApplicableUastTypes + visitAnnotation, which avoids the duplicate-fire issue caused by Kotlin @target(PROPERTY, FIELD) generating two UAST annotation nodes from the same KtAnnotationEntry. Deduplicates remaining visits via sourcePsi identity tracking within the file handler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kirich1409
changed the title
kirich1409
changed the title
2 tasks
kirich1409
added a commit
that referenced
this pull request
May 17, 2026
Rename [Unreleased] to [1.0.0-Beta1] - 2026-05-17, add empty [Unreleased] section, add compare-link, restructure Added section by area, and backfill items audited against git log: - Added: enum DSL (#162), CC support (#164), JavaPreferences default (#167), lint detectors (#141, #176, #181), Detekt rules (#142), FlagRegistry codegen (#110), AGP Variant ProGuard auto-wire, E2E test, R8 DCE module (#165), SECURITY.md (#173), GH templates (#175). - Changed: AGP 9.1 / Gradle 9.3 migration (#135), providers/ directory reshuffle (#128). - Removed: BCV plugin (#150), @LocalFlag/@RemoteFlag. - Fixed: Firebase wrap RuntimeException (#151), MIT POM (#174), quickstart artifact IDs (#179). Closes #166.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three Android Lint detectors to
featured-lint-rules.Closes #157
Closes #158
Closes #159
Changes
UncheckedFlagAccessDetector
UAST scanner for
UCallExpression. Resolves@BehindFlagvia PSI (SOURCE retention workaround). Walks the UAST parent chain for guard contexts:if/whenreferencing the flag by name, or an enclosing@BehindFlag-annotated function. v1 scope: direct calls only — callable references, companion scope escape, and@AssumesFlagdeferred.ExpiredFeatureFlagDetector
Visits
@ExpiresAtannotations onConfigParamproperties. Parses the ISO-8601 date and reports if it is in the past. Deduplicates viavisitedSourceElementsto avoid double-firing from@Target(PROPERTY, FIELD).InvalidFlagReferenceDetector
File-level UAST scanner. Collects
ConfigParamproperty names in the file, then validates@BehindFlag/@AssumesFlagflagNamearguments against them. Skips files with noConfigParamdeclarations to avoid false positives on generated code.Tests
27/27 tests pass (positive + negative cases for each detector).