Open
Conversation
Wrap TerminalViewRepresentable in a clipped rounded container with DS.Spacing.md padding so the terminal no longer bleeds to the window edges. DS.Color.surfaceWindow fills the surrounding chrome. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Frames the terminal canvas in the main agent session view so it no longer renders edge-to-edge, allowing the window chrome/surface color to show around the terminal for a less cramped feel.
Changes:
- Wrapes the terminal content (and connecting-state
Color.blackfallback) in a clipped, rounded container and adds design-system padding. - Adds a window-surface background behind the terminal area so the padding region adapts correctly across appearance modes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Design-review feedback on PR #247: - Padding DS.Spacing.md → xs: 16pt was too generous for a content canvas. - Radius DS.Radius.md → sm: parent NSWindow rounds ~10pt; child surface reads as distinctly smaller. - Surface DS.Color.surfaceWindow → surfaceContent: windowBackgroundColor is the default fill and was near no-op; controlBackgroundColor makes the frame read as a distinct chrome band. - Drop Divider() between canvas and status bar; surface-contrast now carries the separation. - Connecting-state fallback reads from EnvironmentValues.terminalTheme instead of literal Color.black, so users on light palettes no longer see a black flash during session startup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The terminal canvas (
AgentTerminalViewinAppRootView) rendered edge-to-edge inside the window, making the agent session feel cramped. Wrap the terminal in a clipped rounded container withDS.Spacing.mdpadding so the window's surface colour shows through around the edges.Changes
AppRootView.swift: wrapTerminalViewRepresentable(and itsColor.blackconnecting-state fallback) in aGroupwith.clipShape(.rect(cornerRadius: DS.Radius.md, style: .continuous))+.padding(DS.Spacing.md).VStackgets.background(DS.Color.surfaceWindow)so the padding area adapts to light/dark/HCR with the rest of the chrome.Color.blackfallback retained — already excluded from theno_color_blackSwiftLint rule in the Relay target for the terminal canvas (Wave 2 rationale, carried through Wave 6).Verification
swiftlint lint --strict— 0 violations in 201 files.xcodebuild build -scheme Relay -destination 'platform=macOS,arch=arm64' CODE_SIGN_IDENTITY=-— BUILD SUCCEEDED.Test plan
🤖 Generated with Claude Code