Add Format.selectionPriority and parse from HLS SCORE#3236
Conversation
tianyif
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The PR looks good to me. I just left one comment on the plan of same support for DASH, and you don't have to address it in this PR.
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review.
| * more preferred format, or {@link #NO_VALUE} if unset. | ||
| * | ||
| * <p>Populated from the HLS {@code SCORE} attribute on {@code EXT-X-STREAM-INF} and {@code | ||
| * EXT-X-I-FRAME-STREAM-INF}, and from the DASH {@code @selectionPriority} attribute on {@code |
There was a problem hiding this comment.
Do you plan to have a similar PR for DASH as well?
There was a problem hiding this comment.
Thank you for reviewing! Yes I do have a local draft PR for DASH support (hence the comment about dash in code as well), which I plan to raise later today since this PR looks good to you. Separated them for easy review. Will tag this PR when I raise the dash one. Thanks!
There was a problem hiding this comment.
Sounds good. To keep the current PR clean for HLS, I will alter this javadoc a bit without mentioning DASH, you can add it back in the next PR for DASH.
8946a7c to
08bedc8
Compare
cbe44ce to
a1937d9
Compare
a1937d9 to
a738942
Compare
Summary
Adds
Format.selectionPriorityand populates it from the HLSSCOREattribute onEXT-X-STREAM-INF/EXT-X-I-FRAME-STREAM-INF.Extraction-only — no selection behavior changes in this PR
Spec
draft-pantos-hls-rfc8216bis-22 §4.4.6.2
(SCORE on EXT-X-STREAM-INF), §4.4.6.3 (inherits to EXT-X-I-FRAME-STREAM-INF), §6.3.1 (client behavior).
Testing
./gradlew :lib-common:test./gradlew :lib-exoplayer-hls:connectedAndroidTestgit diff -U0 main... | google-java-format-diff.py -p1 -i