Skip to content

Add fallback checks in nativeDataFusionScan for unsupported features #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove wants to merge 5 commits into from
Closed

Add fallback checks in nativeDataFusionScan for unsupported features #7

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e7ab2c
Add fallback checks in nativeDataFusionScan for unsupported features
andygrove Jan 29, 2026
788483e
fix
andygrove Jan 29, 2026
abd0fa6
Merge remote-tracking branch 'apache/main' into native-df-scan-fallbacks
andygrove Feb 4, 2026
e9ea9b4
Remove bucketed scan fallback for native DataFusion scan
andygrove Feb 4, 2026
7e16814
Merge remote-tracking branch 'apache/main' into native-df-scan-fallbacks
andygrove Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spark/src/main/scala/org/apache/comet/serde/operator/CometNativeScan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import org.apache.comet.serde.{CometOperatorSerde, Compatible, OperatorOuterClas
import org.apache.comet.serde.ExprOuterClass.Expr
import org.apache.comet.serde.OperatorOuterClass.Operator
import org.apache.comet.serde.QueryPlanSerde.{exprToProto, serializeDataType}
import org.apache.comet.shims.ShimFileFormat

/**
* Validation and serde logic for `native_datafusion` scans.
Expand Down Expand Up @@ -77,6 +78,14 @@ object CometNativeScan extends CometOperatorSerde[CometScanExec] with Logging {
withInfo(scanExec, "Full native scan disabled because ignoreMissingFiles enabled")
}

if (scanExec.fileConstantMetadataColumns.nonEmpty) {
withInfo(scanExec, "Native DataFusion scan does not support metadata columns")
}

if (ShimFileFormat.findRowIndexColumnIndexInSchema(scanExec.requiredSchema) >= 0) {
withInfo(scanExec, "Native DataFusion scan does not support row index generation")
}

// the scan is supported if no fallback reasons were added to the node
!hasExplainInfo(scanExec)
}
Expand Down
Loading