ci: improvements

* fix: type errors

* ci: improves

* ci: fix test

* ci: test simple

* ci: workflow_run fix?

Author: andykenward

.github/workflows/check-dist.yml

@@ -8,16 +8,10 @@
 name: check dist
 
 on:
-  push:
-    branches:
-      - main
-    paths-ignore:
-      - '**.md'
-  pull_request:
-    branches:
-      - main
-    paths-ignore:
-      - '**.md'
+  workflow_run:
+    workflows: ['test']
+    types:
+      - completed
   workflow_dispatch:
 
 concurrency:
@@ -26,6 +20,7 @@ concurrency:
 
 jobs:
   check-dist:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:

.github/workflows/deploy.yml

@@ -2,12 +2,10 @@
 
 name: deploy
 on:
-  pull_request:
-    branches:
-      - main
-  push:
-    branches:
-      - main
+  workflow_run:
+    workflows: ['test', 'check dist']
+    types:
+      - completed
   workflow_dispatch:
     inputs:
       environment:
@@ -20,6 +18,7 @@ concurrency:
 
 jobs:
   cloudflare-pages-deploy:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     permissions:
       actions: read
       contents: read

.github/workflows/release.yml

@@ -4,12 +4,9 @@ name: release
 
 on:
   workflow_run:
-    workflows:
-      - test
-    branches:
-      - main
-    types:
-      - completed
+    workflows: [test, check dist]
+    branches: [main]
+    types: [completed]
 
 concurrency: ${{ github.workflow }}-${{ github.ref }}
 

.github/workflows/test.yml

@@ -25,5 +25,7 @@ jobs:
           node-version: 20
       - name: Lint
         run: pnpm run lint
+      - name: Typecheck
+        run: pnpm run tsc:check
       - name: Test
         run: pnpm run test:ci

.github/workflows/typecheck.yml

@@ -2,7 +2,7 @@ import * as core from '@actions/core'
 import {afterEach, beforeEach, describe, expect, test, vi} from 'vitest'
 
 import {DeploymentState, DeploymentStatusState} from '@/gql/graphql.js'
-import RESPONSE_CLOUDFLARE_DEPLOYMENT_DELETE from '@/responses/api.cloudflare.com/pages/deployments/deployments-delete.response.json'
+import RESPONSE_CLOUDFLARE_DEPLOYMENT_DELETE from '@/responses/api.cloudflare.com/pages/deployments/deployments-delete.response.json' with {type: 'json'}
 
 import {batchDelete} from '@/common/batch-delete.js'
 import {getCloudflareLogEndpoint} from '@/common/cloudflare/api/endpoints.js'

__mocks__/wrangler.ts

@@ -3,9 +3,9 @@ import {afterEach, beforeEach, describe, expect, test, vi} from 'vitest'
 
 import type {MockApi} from '@/tests/helpers/api.js'
 
-import RESPONSE_NOT_FOUND from '@/responses/api.cloudflare.com/pages/projects/project-not-found.response.json'
-import RESPONSE_OK from '@/responses/api.cloudflare.com/pages/projects/project.response.json'
-import RESPONSE_UNAUTHORIZED from '@/responses/api.cloudflare.com/unauthorized.response.json'
+import RESPONSE_NOT_FOUND from '@/responses/api.cloudflare.com/pages/projects/project-not-found.response.json' with {type: 'json'}
+import RESPONSE_OK from '@/responses/api.cloudflare.com/pages/projects/project.response.json' with {type: 'json'}
+import RESPONSE_UNAUTHORIZED from '@/responses/api.cloudflare.com/unauthorized.response.json' with {type: 'json'}
 import {getMockApi} from '@/tests/helpers/api.js'
 
 import {fetchResult} from '@/common/cloudflare/api/fetch-result.js'

__tests__/common/batch-delete.test.ts

@@ -3,9 +3,9 @@ import {afterEach, beforeEach, describe, expect, test, vi} from 'vitest'
 
 import type {MockApi} from '@/tests/helpers/api.js'
 
-import RESPONSE_NOT_FOUND_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments-not-found.response.json'
-import RESPONSE_DEPLOYMENTS_IDLE from '@/responses/api.cloudflare.com/pages/deployments/deployments.idle.response.json'
-import RESPONSE_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments.response.json'
+import RESPONSE_NOT_FOUND_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments-not-found.response.json' with {type: 'json'}
+import RESPONSE_DEPLOYMENTS_IDLE from '@/responses/api.cloudflare.com/pages/deployments/deployments.idle.response.json' with {type: 'json'}
+import RESPONSE_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments.response.json' with {type: 'json'}
 import {MOCK_API_PATH_DEPLOYMENTS, setMockApi} from '@/tests/helpers/api.js'
 import {stubInputEnv} from '@/tests/helpers/inputs.js'
 

__tests__/common/cloudflare/api/fetch-result.test.ts

@@ -2,7 +2,7 @@ import {afterEach, beforeEach, describe, expect, test, vi} from 'vitest'
 
 import type {MockApi} from '@/tests/helpers/api.js'
 
-import RESPONSE_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments.response.json'
+import RESPONSE_DEPLOYMENTS from '@/responses/api.cloudflare.com/pages/deployments/deployments.response.json' with {type: 'json'}
 import {setMockApi} from '@/tests/helpers/api.js'
 import {EVENT_NAMES} from '@/types/github/workflow-events.js'