ci: workflow consistency tweaks#772
Merged
Merged
Conversation
- zizmor: target `pull_request` at `main` to match every other workflow (all PRs base on main), and normalize the two SHA-pin comments to the repo's `#vX.Y.Z` style (no space). - deploy-main: skip docs-only pushes via `paths-ignore: ['**.md']`; the deploy target is `example/`, unaffected by repo markdown, and no cleanup depends on this job running. Deliberately not adding paths-ignore to deploy-delete: deploy.yml creates a preview for every PR (no path filter), so deploy-delete must run on every close to clean up md-only PRs' previews. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small consistency cleanups across workflow triggers and pin comments (item #4 from the workflow review).
Changes
pull_requestnow targetsbranches: [main]instead of['**'], matching every other workflow. All PRs base onmain, so this is no behavior change in practice — just consistency.# vX.Y.Zto the repo's#vX.Y.Zstyle (these were the only two outliers; the other 23 pins already use no-space).paths-ignore: ['**.md']to skip docs-only pushes tomain. Safe here: the deploy target isexample/(unaffected by repo markdown), and nothing downstream depends on this job running.Deliberately not changed
deploy-delete.ymlwas also flagged forpaths-ignore, but adding it would be a bug:deploy.ymlcreates a preview deployment for every PR (no path filter), sodeploy-deletemust run on every PR close to clean up — including docs-only PRs. Apaths-ignorethere would orphan those previews.Notes
🤖 Generated with Claude Code