Daily compatibility for getGameByID#27
Conversation
update version number
some stuff that makes daily games detectable with getgamebyid
|
There are a few linting errors (just style requirements) and you should be able to view those from the PR. I wasn't aware of the daily endpoint but I think that'd be a great addition. I'm a bit wary of this endpoint just because it isn't approved by Chess.com. Given that it isn't an official endpoint, checking the character count of Ids might not be the best solution. Chess.com could decide to change that on a whim. It's a private endpoint so they have no obligation to keep the interface the same. Probably best to create two endpoints. |
|
Let me know if this is something you want to tackle and update the PR. If it's your first PR I'm stoked to have you contribute! If you're not interested I can always handle adding it. :) |
|
I think it would probably be better for you to do it since you actually seem to know what your doing, but I think it would be a nice feature to add. Just not sure if I implemented it correctly, especially seeing the Lint check seems unhappy. |
Summary
Fixes issue #20 while still having support for rapid games.
Other Information
First pull request so I might have done something wrong.
The test script crashes when reaching the queue test, but game test passes, so its probably fine (sarcasm)