Skip to content

Commit ac5a588

Browse files
Merge pull request #50 from wolfmanfx/main
fix: adjust distance limits for city 3D component interaction
2 parents af78ef2 + 56077cd commit ac5a588

3 files changed

Lines changed: 11 additions & 20 deletions

File tree

.detective/config.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
{
2-
"scopes": [
3-
"apps/backend/src/infrastructure",
4-
"apps/backend/src/mcp",
5-
"apps/backend/src/model",
6-
"apps/backend/src/options",
7-
"apps/backend/src/services",
8-
"apps/backend/src/utils",
9-
"apps/frontend"
10-
],
11-
"groups": ["apps/backend/src", "apps/backend", "apps"],
2+
"scopes": ["apps"],
3+
"groups": [],
124
"entries": [],
135
"filter": {
146
"files": [],

apps/backend/src/services/team-alignment.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,18 @@ export async function calcTeamAlignment(
4242

4343
if (options.demoMode) {
4444
count++;
45-
if (count % 4 === 1) {
46-
userName = 'Max Muster';
47-
} else if (count % 4 === 2) {
48-
userName = 'John Doe';
49-
} else if (count % 4 == 3) {
50-
userName = 'Jane Doe';
51-
}
45+
const demoUsers = ['Max Muster', 'John Doe', 'Jane Doe', 'Maria Muster'];
46+
userName = demoUsers[(count - 1) % demoUsers.length];
5247
}
5348

5449
userName = config.aliases?.[userName] || userName;
5550

5651
const emailLower = (entry.header.email || '').toLowerCase();
57-
const stableUserKey = byUser ? emailLower || userName : userName;
52+
const stableUserKey = byUser
53+
? options.demoMode
54+
? userName
55+
: emailLower || userName
56+
: userName;
5857

5958
if (!userKeyToDisplay[stableUserKey]) {
6059
userKeyToDisplay[stableUserKey] = userName;

apps/frontend/src/app/features/hotspot-city/city3d.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class City3DComponent implements OnChanges, OnDestroy {
8686
private targetRotationY = 0;
8787
private targetPanX = 0;
8888
private targetPanZ = 0;
89-
private distance = 100;
89+
private distance = 20;
9090

9191
ngOnChanges(changes: SimpleChanges): void {
9292
if (changes['items'] || changes['mode']) {
@@ -443,7 +443,7 @@ export class City3DComponent implements OnChanges, OnDestroy {
443443
if (!this.renderer || !target || !this.renderer.domElement.contains(target))
444444
return;
445445
this.distance += event.deltaY * 0.05;
446-
this.distance = Math.max(20, Math.min(4000, this.distance));
446+
this.distance = Math.max(0, this.distance);
447447
event.preventDefault();
448448
}
449449

0 commit comments

Comments
 (0)