Merge pull request #45 from wolfmanfx/main

refactor: remove ts-morph dependency and simplify unused members metr…

Author: manfredsteyer

.detective/config.json

@@ -1,12 +1,12 @@
 {
   "scopes": [
-    "apps/frontend",
     "apps/backend/src/infrastructure",
     "apps/backend/src/mcp",
     "apps/backend/src/model",
     "apps/backend/src/options",
     "apps/backend/src/services",
-    "apps/backend/src/utils"
+    "apps/backend/src/utils",
+    "apps/frontend"
   ],
   "groups": ["apps/backend/src", "apps/backend", "apps"],
   "entries": [],

.detective/hash

@@ -1 +1 @@
-0a7d0219e81ae606e07a3ab3fedd5499f9db7f49, v1.3.0
+1b2f59522186c242168b2282b7815a75b48d7a6b, v1.3.0

apps/backend/src/services/trend-analysis/x-ray/class-metrics-analyzer.ts

@@ -53,6 +53,7 @@ export class ClassMetricsAnalyzer extends BaseMetricsAnalyzer {
     const allSections = [
       ...(reasonsMeta.ui.sections ?? []),
       ...(duplicateMeta.ui.sections ?? []),
+      ...(unusedMeta.ui.sections ?? []),
     ];
 
     return {
@@ -96,7 +97,7 @@ export class ClassMetricsAnalyzer extends BaseMetricsAnalyzer {
       complexity,
       dependencyAnalysis,
       reasonsMetric,
-      unusedMembers,
+      unusedMembersResult,
       duplicateAnalysis,
     ] = await Promise.all([
       this.complexityMetric.analyzeAsync({ ...this.context, scopeNode: node }),
@@ -143,7 +144,8 @@ export class ClassMetricsAnalyzer extends BaseMetricsAnalyzer {
       internalFiles: reasonsMetric.internalFiles,
 
       // Code quality metrics
-      unusedMembers: unusedMembers,
+      unusedMembers: unusedMembersResult.unusedMembers,
+      unusedMemberNames: unusedMembersResult.unusedMemberNames,
       duplicateBlocks,
       duplicateDetails,
     };

apps/backend/src/services/trend-analysis/x-ray/metrics/unused-members.metric.spec.ts

@@ -33,14 +33,15 @@ describe('UnusedMembersMetric', () => {
       }
     `;
     const { sourceFile, classNode, program, checker } = buildContext(code);
-    const count = metric.analyze({
+    const result = metric.analyze({
       sourceFile,
       program,
       checker,
       sourceCode: code,
       scopeNode: classNode,
     });
-    expect(count).toBe(5);
+    expect(result.unusedMembers).toBe(5);
+    expect(result.unusedMemberNames?.length).toBe(5);
   });
 
   it('detects unused members with usage patterns', () => {
@@ -61,14 +62,17 @@ describe('UnusedMembersMetric', () => {
       }
     `;
     const { sourceFile, classNode, program, checker } = buildContext(code);
-    const count = metric.analyze({
+    const result = metric.analyze({
       sourceFile,
       program,
       checker,
       sourceCode: code,
       scopeNode: classNode,
     });
-    expect(count).toBe(3);
+    expect(result.unusedMembers).toBe(3);
+    expect(result.unusedMemberNames).toEqual(
+      expect.arrayContaining(['unused1', 'unused2', '#unusedSuper'])
+    );
   });
 
   it('detects unused constructor parameter properties', () => {
@@ -78,14 +82,15 @@ describe('UnusedMembersMetric', () => {
       }
     `;
     const { sourceFile, classNode, program, checker } = buildContext(code);
-    const count = metric.analyze({
+    const result = metric.analyze({
       sourceFile,
       program,
       checker,
       sourceCode: code,
       scopeNode: classNode,
     });
-    expect(count).toBe(1);
+    expect(result.unusedMembers).toBe(1);
+    expect(result.unusedMemberNames).toEqual(['unused']);
   });
 
   it('finds no unused members when all are used or public', () => {
@@ -110,13 +115,43 @@ describe('UnusedMembersMetric', () => {
       }
     `;
     const { sourceFile, classNode, program, checker } = buildContext(code);
-    const count = metric.analyze({
+    const result = metric.analyze({
+      sourceFile,
+      program,
+      checker,
+      sourceCode: code,
+      scopeNode: classNode,
+    });
+    expect(result.unusedMembers).toBe(0);
+    expect(result.unusedMemberNames).toEqual([]);
+  });
+
+  it('does not flag private static members used via ClassName access', () => {
+    const code = `
+      class Example {
+        private static readonly CONST = new Set(['a']);
+        private static helper() { return 'ok'; }
+        private value = 'v';
+
+        method() {
+          if (Example.CONST.has('a')) {
+            (Example as any).helper();
+          }
+          // also ensure element access is handled
+          const c = (Example as any)['CONST'];
+          this.value = 'x';
+        }
+      }
+    `;
+    const { sourceFile, classNode, program, checker } = buildContext(code);
+    const result = metric.analyze({
       sourceFile,
       program,
       checker,
       sourceCode: code,
       scopeNode: classNode,
     });
-    expect(count).toBe(0);
+    expect(result.unusedMembers).toBe(0);
+    expect(result.unusedMemberNames).toEqual([]);
   });
 });