Skip to content

Commit 281bb91

Browse files
authored
Merge pull request #1092 from /issues/1091
fix: downgraded ESbuild to 0.27.3 because of infinite loop bug
2 parents 8493c7a + 00ffdbf commit 281bb91

File tree

4 files changed

+1112
-2025
lines changed

4 files changed

+1112
-2025
lines changed

libs/native-federation/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"@chialab/esbuild-plugin-commonjs": "^0.19.0",
2626
"@angular/build": "^21.2.0",
2727
"@angular-devkit/build-angular": "^21.2.0",
28-
"esbuild": "^0.27.1",
28+
"esbuild": ">=0.27.1 <0.27.4 || >0.27.4",
2929
"mrmime": "^2.0.1",
3030
"signale": "^1.4.0",
3131
"process": "0.11.10"

libs/native-federation/src/builders/build/builder.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,12 @@ export async function* runBuilder(
402402
// yield output;
403403
// }
404404

405-
if (!first && (nfOptions.dev || watch)) {
405+
if (!output.success && isLocalDevelopment) {
406+
federationBuildNotifier.broadcastBuildError(
407+
new Error(output?.error ?? 'Angular build failed.'),
408+
);
409+
}
410+
if (!first && output.success && (nfOptions.dev || watch)) {
406411
rebuildQueue
407412
.enqueue(async (signal: AbortSignal) => {
408413
if (signal?.aborted) {

0 commit comments

Comments
 (0)