Skip to content

Commit 82f84b8

Browse files
committed
fix(1006): Support for windows paths
1 parent 89f9d20 commit 82f84b8

4 files changed

Lines changed: 14 additions & 3 deletions

File tree

libs/native-federation-core/src/lib/core/build-for-federation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { FederationOptions } from './federation-options';
1414
import { writeFederationInfo } from './write-federation-info';
1515
import { writeImportMap } from './write-import-map';
1616
import { logger } from '../utils/logger';
17-
import { getCachePath } from './bundle-caching';
17+
import { getCachePath } from './../utils/bundle-caching';
1818
import { normalizePackageName } from '../utils/normalize';
1919
import { AbortedError } from '../utils/errors';
2020

libs/native-federation-core/src/lib/core/bundle-shared.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@ import {
1717
isSourceFile,
1818
rewriteChunkImports,
1919
} from '../utils/rewrite-chunk-imports';
20-
import { cacheEntry, getChecksum, getFilename } from './bundle-caching';
20+
import {
21+
cacheEntry,
22+
getChecksum,
23+
getFilename,
24+
} from './../utils/bundle-caching';
25+
import { getSeparator } from '../utils/mapped-paths';
2126

2227
export async function bundleShared(
2328
sharedBundles: Record<string, NormalizedSharedConfig>,
@@ -172,7 +177,9 @@ export async function bundleShared(
172177
bundleCache.persist({
173178
checksum,
174179
externals: result,
175-
files: bundleResult.map((r) => r.fileName.split('/').pop() ?? r.fileName),
180+
files: bundleResult.map(
181+
(r) => r.fileName.split(getSeparator(r.fileName)).pop() ?? r.fileName,
182+
),
176183
});
177184

178185
bundleCache.copyFiles(

libs/native-federation-core/src/lib/core/bundle-caching.ts renamed to libs/native-federation-core/src/lib/utils/bundle-caching.ts

File renamed without changes.

libs/native-federation-core/src/lib/utils/mapped-paths.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ export interface GetMappedPathsOptions {
1313
rootPath?: string;
1414
}
1515

16+
export function getSeparator(path: string) {
17+
return path.includes('\\') ? '\\' : '/';
18+
}
19+
1620
export function getMappedPaths({
1721
rootTsConfigPath,
1822
sharedMappings,

0 commit comments

Comments
 (0)