fix(all): Fixed audit vulnerabilities + moved cache options

Author: Aukevanoost

libs/native-federation-core/src/lib/config/federation-config.ts

@@ -27,7 +27,6 @@ export interface FederationConfig {
   features?: {
     mappingVersion?: boolean;
     ignoreUnusedDeps?: boolean;
-    cacheExternalArtifacts: boolean;
   };
 }
 
@@ -56,6 +55,5 @@ export interface NormalizedFederationConfig {
   features: {
     mappingVersion: boolean;
     ignoreUnusedDeps: boolean;
-    cacheExternalArtifacts: boolean;
   };
 }

libs/native-federation-core/src/lib/config/with-native-federation.ts

@@ -28,7 +28,6 @@ export function withNativeFederation(
     features: {
       mappingVersion: config.features?.mappingVersion ?? false,
       ignoreUnusedDeps: config.features?.ignoreUnusedDeps ?? false,
-      cacheExternalArtifacts: config.features?.cacheExternalArtifacts ?? false,
     },
   };
 

libs/native-federation-core/src/lib/core/bundle-shared.ts

@@ -37,7 +37,7 @@ export async function bundleShared(
     getFilename(cacheOptions.bundleName),
   );
 
-  if (config?.features?.cacheExternalArtifacts) {
+  if (fedOptions?.cacheExternalArtifacts) {
     const cacheMetadata = bundleCache.getMetadata(checksum);
     if (cacheMetadata) {
       logger.debug(

libs/native-federation-core/src/lib/core/federation-options.ts

@@ -4,7 +4,7 @@ export interface FederationOptions {
   workspaceRoot: string;
   outputPath: string;
   federationConfig: string;
-  cacheExternals: boolean;
+  cacheExternalArtifacts?: boolean;
   tsConfig?: string;
   verbose?: boolean;
   dev?: boolean;

libs/native-federation/src/builders/build/builder.ts

@@ -226,6 +226,7 @@ export async function* runBuilder(
     dev: !!nfOptions.dev,
     entryPoint,
     buildNotifications: nfOptions.buildNotifications,
+    cacheExternalArtifacts: nfOptions.cacheExternalArtifacts,
   };
 
   const activateSsr = nfOptions.ssr && !nfOptions.dev;

libs/native-federation/src/builders/build/schema.d.ts

@@ -17,4 +17,5 @@ export interface NfBuilderSchema extends JsonObject {
   outputPath?: string;
   ssr: boolean;
   devServer?: boolean;
+  cacheExternalArtifacts?: boolean;
 } // eslint-disable-line

libs/native-federation/src/schematics/init/files/federation.config.js__tmpl__

@@ -28,11 +28,6 @@ module.exports = withNativeFederation({
     // New feature for more performance and avoiding
     // issues with node libs. Comment this out to
     // get the traditional behavior:
-    ignoreUnusedDeps: true,
-
-    // Will use a checksum to verify if compiled (external) 
-    // artifacts were unchanged since last build (based on 
-    // name and version). If so it will reuse the compiled ones.
-    cacheExternalArtifacts: true
+    ignoreUnusedDeps: true
   }
 });

libs/native-federation/src/schematics/init/schematic.ts

@@ -302,6 +302,7 @@ function updateWorkspaceConfig(
       target: `${projectName}:serve-original:development`,
       rebuildDelay: 500,
       dev: true,
+      cacheExternalArtifacts: false,
       port: 0,
     },
   };