refactor: simplify updateSalutationAndPronoun logic

Author: d-koppenhagen

src/app/identity-form/identity-form.html

@@ -3,7 +3,7 @@
   <select
     name="gender-identity"
     [field]="identity().gender"
-    (change)="maybeUpdateSalutationAndPronoun()"
+    (change)="updateSalutationAndPronoun()"
   >
     <option value="" selected>Please select</option>
     <option value="male">Male</option>

src/app/identity-form/identity-form.ts

@@ -42,14 +42,10 @@ export const identitySchema = schema<GenderIdentity>((path) => {
 export class IdentityForm {
   readonly identity = input.required<FieldTree<GenderIdentity>>();
 
-  protected maybeUpdateSalutationAndPronoun() {
-    const gender = this.identity().gender().value();
-    if (gender !== 'diverse') {
-      this.identity().salutation().value.set('');
-      this.identity().pronoun().value.set('');
-    } else {
-      this.identity().salutation().reset();
-      this.identity().pronoun().reset();
-    }
+  protected updateSalutationAndPronoun() {
+    this.identity().salutation().value.set('');
+    this.identity().salutation().reset();
+    this.identity().pronoun().value.set('');
+    this.identity().pronoun().reset();
   }
 }