feat: cva for directives

Author: tomastrajan

src/converters/directive/directive.converter.spec.ts

@@ -10,6 +10,7 @@ describe('Directive converter', () => {
         className: 'first',
         selector: 'first',
         standalone: true,
+        cva: false,
         inputs: [],
         outputs: [],
         implementation: '',
@@ -23,6 +24,7 @@ describe('Directive converter', () => {
         className: 'second',
         selector: 'second',
         standalone: false,
+        cva: false,
         inputs: [],
         outputs: [],
         implementation: '',
@@ -36,6 +38,7 @@ describe('Directive converter', () => {
         className: 'third',
         selector: 'third',
         standalone: true,
+        cva: false,
         inputs: [],
         outputs: [],
         implementation: '',

src/parser/component/component.parser.ts

@@ -3,14 +3,15 @@ import { readFileSync } from 'fs';
 import * as ts from 'typescript';
 import { tsquery } from '@phenomnomnominal/tsquery';
 
-import { parseInputsAndOutputs } from '../shared/parser/field-decorator.parser.js';
-import { parseExplicitPublicMethods, parseMethods } from '../shared/parser/method.parser.js';
+import { isCva } from '../shared/parser/cva.parser.js';
 import { NgParselOutputType } from '../shared/model/types.model.js';
+import { parseInputsAndOutputs } from '../shared/parser/field-decorator.parser.js';
+import { getDecoratorProperties } from '../shared/parser/decorator.parser.js';
+import { parseExplicitPublicFields } from '../shared/parser/field.parser.js';
 import { parseClassName, parseClassJsDoc } from '../shared/parser/class.parser.js';
+import { parseExplicitPublicMethods, parseMethods } from '../shared/parser/method.parser.js';
 
 import { NgParselComponent } from './component.model.js';
-import { getDecoratorProperties } from '../shared/parser/decorator.parser.js';
-import { parseExplicitPublicFields } from '../shared/parser/field.parser.js';
 
 export function parseComponent(ast: ts.SourceFile, componentFilePath: string): NgParselComponent {
   const componentDecorators = getDecoratorProperties(ast);
@@ -46,13 +47,6 @@ export function parseComponent(ast: ts.SourceFile, componentFilePath: string): N
   };
 }
 
-function isCva(ast: ts.SourceFile): boolean {
-  return (
-    tsquery(ast, 'HeritageClause > ExpressionWithTypeArguments > Identifier:has([escapedText="ControlValueAccessor"])')
-      .length > 0
-  );
-}
-
 function isOnPushChangeDetection(ast: ts.SourceFile): boolean {
   const changeDetectionNodes = tsquery(
     ast,

src/parser/directive/directive.model.ts

@@ -7,6 +7,7 @@ export interface NgParselDirective extends NgParselOutput {
   className: string;
   selector: string;
   standalone: boolean;
+  cva: boolean;
   implementation: string;
   inputs: NgParselFieldDecorator[];
   outputs: NgParselFieldDecorator[];

src/parser/directive/directive.parser.spec.ts

@@ -31,6 +31,7 @@ describe('DirectiveParser', () => {
       filePath,
       selector: '[myTestDirective]',
       standalone: false,
+      cva: false,
       inputs: [
         {
           decorator: '@Input()',
@@ -88,6 +89,7 @@ describe('DirectiveParser', () => {
       filePath,
       selector: '[myTestDirective]',
       standalone: true,
+      cva: false,
       inputs: [
         {
           decorator: '@Input()',

src/parser/directive/directive.parser.ts

@@ -1,14 +1,15 @@
 import { readFileSync } from 'fs';
 import * as ts from 'typescript';
 
-import { parseClassName, parseClassJsDoc } from '../shared/parser/class.parser.js';
+import { isCva } from '../shared/parser/cva.parser.js';
 import { NgParselOutputType } from '../shared/model/types.model.js';
-import { getDecoratorProperties } from '../shared/parser/decorator.parser.js';
 import { parseInputsAndOutputs } from '../shared/parser/field-decorator.parser.js';
+import { getDecoratorProperties } from '../shared/parser/decorator.parser.js';
+import { parseExplicitPublicFields } from '../shared/parser/field.parser.js';
+import { parseClassName, parseClassJsDoc } from '../shared/parser/class.parser.js';
+import { parseExplicitPublicMethods, parseMethods } from '../shared/parser/method.parser.js';
 
 import { NgParselDirective } from './directive.model.js';
-import { parseExplicitPublicMethods, parseMethods } from '../shared/parser/method.parser.js';
-import { parseExplicitPublicFields } from '../shared/parser/field.parser.js';
 
 export function parseDirective(ast: ts.SourceFile, directiveFilePath: string): NgParselDirective {
   const directiveDecorators = getDecoratorProperties(ast);
@@ -23,6 +24,7 @@ export function parseDirective(ast: ts.SourceFile, directiveFilePath: string): N
     filePath: directiveFilePath,
     selector: directiveDecorators.selector as string,
     standalone: directiveDecorators.standalone || false,
+    cva: isCva(ast),
     implementation: directiveImplementation,
     inputs: inputsAndOutputs.inputs,
     outputs: inputsAndOutputs.outputs,

src/parser/shared/parser/cva.parser.spec.ts

@@ -0,0 +1,40 @@
+import { tsquery } from '@phenomnomnominal/tsquery';
+import { isCva } from './cva.parser.js';
+
+describe('isCva', () => {
+  it('detects ControlValueAccessor on a component AST that implements it', () => {
+    const ast = tsquery.ast(`
+      @Component({ selector: 'cva-comp', template: '' })
+      export class MyComponent implements ControlValueAccessor {}
+    `);
+
+    expect(isCva(ast)).toEqual(true);
+  });
+
+  it('does not detect ControlValueAccessor on a component AST that does not implement it', () => {
+    const ast = tsquery.ast(`
+      @Component({ selector: 'no-cva-comp', template: '' })
+      export class MyComponent {}
+    `);
+
+    expect(isCva(ast)).toEqual(false);
+  });
+
+  it('detects ControlValueAccessor on a directive AST that implements it', () => {
+    const ast = tsquery.ast(`
+      @Directive({ selector: '[myDir]' })
+      export class MyDirective implements ControlValueAccessor {}
+    `);
+
+    expect(isCva(ast)).toEqual(true);
+  });
+
+  it('does not detect ControlValueAccessor on a directive AST that does not implement it', () => {
+    const ast = tsquery.ast(`
+      @Directive({ selector: '[myDir]' })
+      export class MyDirective {}
+    `);
+
+    expect(isCva(ast)).toEqual(false);
+  });
+});

src/parser/shared/parser/cva.parser.ts

@@ -0,0 +1,9 @@
+import * as ts from 'typescript';
+import { tsquery } from '@phenomnomnominal/tsquery';
+
+export function isCva(ast: ts.SourceFile): boolean {
+  return (
+    tsquery(ast, 'HeritageClause > ExpressionWithTypeArguments > Identifier:has([escapedText="ControlValueAccessor"])')
+      .length > 0
+  );
+}