Example of using immutable.js and reselect#145
Open
hangzho wants to merge 1 commit intoangular-redux:masterfrom
Open
Example of using immutable.js and reselect#145hangzho wants to merge 1 commit intoangular-redux:masterfrom
hangzho wants to merge 1 commit intoangular-redux:masterfrom
Conversation
1. Duplicate the ‘async’ example and upgrade the html-webpack-plugin. 2. Refactor the code to use Immutablejs and reselect.
dayfine
reviewed
Jun 18, 2018
| @@ -0,0 +1,23 @@ | |||
| import { createStore, applyMiddleware } from 'redux'; | |||
There was a problem hiding this comment.
Is this file from another example? And I don't think it's actually used anywhere, right?
Author
There was a problem hiding this comment.
Yes, the code is originally from https://github.com/angular-redux/ng-redux/tree/master/examples/async. I think you are right. The file isn't used in this example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, I was playing around with ng-redux, immutable and reselect.
Basically I duplicated the async example from the repository and refactored the code by using immutable and reselect libraries. I guess it might be helpful for someone else.