test(@angular/cli): remove unscoped authentication test cases from registry tests

Modern package managers do not support unscoped authentication, and Yarn Classic's
metadata command (yarn info) does not propagate unscoped credentials correctly,
leading to 403 Forbidden failures on secure registries during ng update and ng add.

This commit removes the unscoped authentication test cases from both add and
update secure registry E2E tests, and cleans up the
createNpmConfigForAuthentication helper to default to scoped authentication.

(cherry picked from commit ecda706)

Author: clydin

tests/e2e/tests/commands/add/secure-registry.ts

@@ -1,5 +1,5 @@
-import { expectFileNotToExist, expectFileToExist, rimraf } from '../../../utils/fs';
-import { getActivePackageManager, installWorkspacePackages } from '../../../utils/packages';
+import { expectFileNotToExist, expectFileToExist } from '../../../utils/fs';
+import { installWorkspacePackages } from '../../../utils/packages';
 import { git, ng } from '../../../utils/process';
 import { createNpmConfigForAuthentication } from '../../../utils/registry';
 import { expectToFail } from '../../../utils/utils';
@@ -9,37 +9,17 @@ export default async function () {
   try {
     // The environment variable has priority over the .npmrc
     delete process.env['NPM_CONFIG_REGISTRY'];
-    const packageManager = getActivePackageManager();
-    const supportsUnscopedAuth = packageManager === 'yarn';
     const command = ['add', '@angular/pwa', '--skip-confirmation'];
 
-    // Works with unscoped registry authentication details
-    if (supportsUnscopedAuth) {
-      // Some package managers such as Bun and NPM do not support unscoped auth.
-      await createNpmConfigForAuthentication(false);
-
-      await expectFileNotToExist('public/manifest.webmanifest');
-
-      await ng(...command);
-      await expectFileToExist('public/manifest.webmanifest');
-      await git('clean', '-dxf');
-    }
-
     // Works with scoped registry authentication details
     await expectFileNotToExist('public/manifest.webmanifest');
 
-    await createNpmConfigForAuthentication(true);
+    await createNpmConfigForAuthentication();
     await ng(...command);
     await expectFileToExist('public/manifest.webmanifest');
     await git('clean', '-dxf');
 
     // Invalid authentication token
-    if (supportsUnscopedAuth) {
-      // Some package managers such as Bun and NPM do not support unscoped auth.
-      await createNpmConfigForAuthentication(false, true);
-      await expectToFail(() => ng(...command));
-    }
-
     await createNpmConfigForAuthentication(true, true);
     await expectToFail(() => ng(...command));
   } finally {

tests/e2e/tests/update/update-secure-registry.ts

@@ -6,9 +6,6 @@ import { getActivePackageManager } from '../../utils/packages';
 import assert from 'node:assert';
 
 export default async function () {
-  const packageManager = getActivePackageManager();
-  const supportsUnscopedAuth = packageManager === 'yarn';
-
   // The environment variable has priority over the .npmrc
   delete process.env['NPM_CONFIG_REGISTRY'];
   const worksMessage = 'We analyzed your package.json';
@@ -20,27 +17,14 @@ export default async function () {
 
   // Valid authentication token
 
-  if (supportsUnscopedAuth) {
-    await createNpmConfigForAuthentication(false);
-    const { stdout: stdout1 } = await ng('update', ...extraArgs);
-    if (!stdout1.includes(worksMessage)) {
-      throw new Error(`Expected stdout to contain "${worksMessage}"`);
-    }
-  }
-
-  await createNpmConfigForAuthentication(true);
+  await createNpmConfigForAuthentication();
   const { stdout: stdout2 } = await ng('update', ...extraArgs);
   if (!stdout2.includes(worksMessage)) {
     throw new Error(`Expected stdout to contain "${worksMessage}"`);
   }
 
   // Invalid authentication token
 
-  if (supportsUnscopedAuth) {
-    await createNpmConfigForAuthentication(false, true);
-    await expectToFail(() => ng('update', ...extraArgs));
-  }
-
   await createNpmConfigForAuthentication(true, true);
   await expectToFail(() => ng('update', ...extraArgs));
 

tests/e2e/utils/registry.ts

@@ -63,7 +63,7 @@ export async function createNpmConfigForAuthentication(
    * _auth="dGVzdGluZzpzM2NyZXQ="`
    * ```
    */
-  scopedAuthentication: boolean,
+  scopedAuthentication = true,
   /** When true, an incorrect token is used. Use this to validate authentication failures. */
   invalidToken = false,
 ): Promise<void> {