chore: remove obsolete TODO and clean up PublishOptions type

- Remove TODO about Commander issue #928 (irrelevant after fork)
- Remove internal options from PublishOptions interface:
  - notfound (angular-cli-ghpages handles 404.html)
  - noDotfiles, noNotfound, noNojekyll (transformed before gh-pages)
  - dryRun (angular-cli-ghpages internal)
- Add documentation clarifying which options gh-pages accepts

Author: JohannesHoppe

src/angular-cli-ghpages

@@ -8,9 +8,8 @@ var path = require('path'),
   pjson = require('./package.json'),
   commander = require('./commander-fork');
 
-// defaults-file was ignored for --no-dotfiles, so it is not used here
-// TODO: review https://github.com/tj/commander.js/issues/928 and check again if it now works
-// (this is not a big problem, because true is currently the desired value and this is also the value in the defaults file)
+// Boolean defaults for --no-X options are handled via defaults.ts
+// Commander v3 auto-sets dotfiles/notfound/nojekyll to true, which matches our defaults
 commander
   .version(pjson.version)
   .description(pjson.description)

src/interfaces.ts

@@ -28,6 +28,10 @@ export interface DeployUser {
 /**
  * Options for gh-pages.publish()
  * Based on https://github.com/tschaub/gh-pages#options
+ *
+ * Note: Only includes options that gh-pages actually accepts.
+ * Internal options (notfound, noDotfiles, noNotfound, noNojekyll, dryRun)
+ * are handled by angular-cli-ghpages before calling gh-pages.
  */
 export interface PublishOptions {
   repo?: string;
@@ -36,15 +40,10 @@ export interface PublishOptions {
   message?: string;
   user?: { name: string; email: string };
   dotfiles?: boolean;
-  notfound?: boolean;
   nojekyll?: boolean;
-  noDotfiles?: boolean;
-  noNotfound?: boolean;
-  noNojekyll?: boolean;
   cname?: string;
   add?: boolean;
   git?: string;
-  dryRun?: boolean;
   [key: string]: unknown; // Allow additional gh-pages options
 }