refactor: improve test quality and code style

- Replace try/catch/fail pattern with await expect().rejects.toThrow()
- Replace lazy .toContain() with precise .toBe() for error messages
- Fix bracket notation: options['user'] → options.user
- Remove obsolete historical documentation about v3 Promise bug

Author: JohannesHoppe

src/deploy/actions.spec.ts

@@ -65,12 +65,10 @@ describe('Deploy Angular apps', () => {
     it('throws if there is no target project', async () => {
       context.target = undefined;
       const expectedErrorMessage = 'Cannot execute the build target';
-      try {
-        await deploy(mockEngine, context, BUILD_TARGET, {});
-        fail();
-      } catch (e) {
-        expect(e.message).toBe(expectedErrorMessage);
-      }
+
+      await expect(
+        deploy(mockEngine, context, BUILD_TARGET, {})
+      ).rejects.toThrow(expectedErrorMessage);
     });
 
     it('throws if app building fails', async () => {
@@ -82,12 +80,10 @@ describe('Deploy Angular apps', () => {
         Promise.resolve({
           result: Promise.resolve(createBuilderOutputMock(false))
         } as BuilderRun);
-      try {
-        await deploy(mockEngine, context, BUILD_TARGET, {});
-        fail();
-      } catch (e) {
-        expect(e.message).toEqual('Error while building the app.');
-      }
+
+      await expect(
+        deploy(mockEngine, context, BUILD_TARGET, {})
+      ).rejects.toThrow('Error while building the app.');
     });
 
     it('throws if outputPath is missing from build options', async () => {
@@ -96,12 +92,9 @@ describe('Deploy Angular apps', () => {
 
       const expectedErrorMessage = `Cannot read the outputPath option of the Angular project '${BUILD_TARGET.name}' in angular.json.`;
 
-      try {
-        await deploy(mockEngine, context, BUILD_TARGET, { noBuild: false });
-        fail();
-      } catch (e) {
-        expect(e.message).toBe(expectedErrorMessage);
-      }
+      await expect(
+        deploy(mockEngine, context, BUILD_TARGET, { noBuild: false })
+      ).rejects.toThrow(expectedErrorMessage);
     });
 
     it('throws if outputPath has invalid shape (not string or object)', async () => {
@@ -110,14 +103,11 @@ describe('Deploy Angular apps', () => {
           outputPath: 123
         } as JsonObject);
 
-      const expectedErrorPrefix = 'Unsupported outputPath configuration';
+      const expectedErrorMessage = `Unsupported outputPath configuration in angular.json for '${BUILD_TARGET.name}'. Expected string or {base, browser} object.`;
 
-      try {
-        await deploy(mockEngine, context, BUILD_TARGET, { noBuild: false });
-        fail();
-      } catch (e) {
-        expect(e.message).toContain(expectedErrorPrefix);
-      }
+      await expect(
+        deploy(mockEngine, context, BUILD_TARGET, { noBuild: false })
+      ).rejects.toThrow(expectedErrorMessage);
     });
 
     it('throws if outputPath object is missing base property', async () => {
@@ -126,14 +116,11 @@ describe('Deploy Angular apps', () => {
           outputPath: { browser: 'browser' }
         } as JsonObject);
 
-      const expectedErrorPrefix = 'Unsupported outputPath configuration';
+      const expectedErrorMessage = `Unsupported outputPath configuration in angular.json for '${BUILD_TARGET.name}'. Expected string or {base, browser} object.`;
 
-      try {
-        await deploy(mockEngine, context, BUILD_TARGET, { noBuild: false });
-        fail();
-      } catch (e) {
-        expect(e.message).toContain(expectedErrorPrefix);
-      }
+      await expect(
+        deploy(mockEngine, context, BUILD_TARGET, { noBuild: false })
+      ).rejects.toThrow(expectedErrorMessage);
     });
 
     it('uses correct dir when outputPath is object with base and browser (OP1)', async () => {

src/engine/engine.gh-pages-behavior.spec.ts

@@ -758,17 +758,11 @@ describe('gh-pages v6.3.0 - behavioral snapshot', () => {
    * 1. Git clone failure and retry (branch doesn't exist)
    * 2. No changes to commit (diff-index returns 0)
    * 3. Git commit when no user configured (uses getUser)
-   * 4. Early error handling (invalid basePath) - PR #186 compatibility
    *
    * Why test error scenarios:
    * - Ensures deployments don't fail silently
    * - Verifies retry/fallback mechanisms work
    * - Documents expected error recovery behavior
-   *
-   * Historical note:
-   * gh-pages v3.1.0 had a bug where early errors didn't return promises.
-   * gh-pages v5.0.0+ fixed this to correctly return Promise.reject().
-   * We now use the Promise-based API directly (await ghPages.publish()).
    */
   describe('Error scenarios', () => {
     it('should retry git clone without branch/depth options on failure', (done) => {
@@ -999,53 +993,6 @@ describe('gh-pages v6.3.0 - behavioral snapshot', () => {
       });
     });
 
-    /**
-     * PR #186 Issue #1: gh-pages Promise Bug (documented here)
-     *
-     * Context from PR #186 analysis:
-     * gh-pages v3.1.0 has a bug where early error cases don't return a promise.
-     * Source: https://github.com/tschaub/gh-pages/blob/v3.1.0/lib/index.js#L78-85
-     *
-     * Evidence from source code:
-     * ```
-     * try {
-     *   if (!fs.statSync(basePath).isDirectory()) {
-     *     done(new Error('The "base" option must be an existing directory'));
-     *     return;  // ❌ NO PROMISE RETURNED!
-     *   }
-     * } catch (err) {
-     *   done(err);
-     *   return;  // ❌ NO PROMISE RETURNED!
-     * }
-     * ```
-     *
-     * Early errors include:
-     * - basePath is not a directory
-     * - basePath doesn't exist
-     * - No files match src pattern
-     *
-     * In gh-pages v3.x, if you used await ghPages.publish(), these errors were silently swallowed!
-     *
-     * HISTORICAL: Our old workaround (REMOVED in v6 upgrade):
-     * ```
-     * // do NOT (!!) await ghPages.publish,
-     * // the promise is implemented in such a way that it always succeeds – even on errors!
-     * return new Promise((resolve, reject) => {
-     *   ghPages.publish(dir, options, error => {
-     *     if (error) { return reject(error); }
-     *     resolve(undefined);
-     *   });
-     * });
-     * ```
-     *
-     * CURRENT (gh-pages v6.3.0):
-     * - Fixed in gh-pages v5.0.0+: All errors correctly return Promise.reject()
-     * - We now use `await ghPages.publish()` directly (engine.ts:203-204)
-     * - The Promise bug is fixed, all error cases properly reject
-     * - This documentation preserved for historical context only
-     *
-     * Current behavior is tested in engine.spec.ts integration tests.
-     */
   });
 
   /**

src/engine/engine.prepare-options-helpers.ts

@@ -104,7 +104,7 @@ export function handleUserCredentials(
   logger: logging.LoggerApi
 ): void {
   if (options.name && options.email) {
-    options['user'] = {
+    options.user = {
       name: options.name,
       email: options.email
     };