test: add comprehensive integration tests for ImportManager (Phase 9.5)

- Created 20 integration tests covering all import organization features
- Fixed critical bug: usage detection was skipping identifiers in variable initializers
- Fixed sorting disabled mode: groups were still sorting internally
- All 21 tests passing (20 ImportManager + 1 sample test)

Test coverage includes:
- Remove unused imports and specifiers
- Keep excluded libraries (ignoredFromRemoval)
- Type-only imports
- Local shadowing
- Aliased imports
- Namespace imports
- Default imports
- Mixed default + named imports
- Import grouping (Plains -> Modules -> Workspace)
- Alphabetical sorting
- Quote style configuration
- Semicolons configuration
- Space in braces configuration
- Blank lines between groups
- Trailing /index removal
- Disable removal option
- Disable sorting option
- String-only imports

Added GitHub Actions workflow to test on Linux/macOS/Windows with xvfb support

Author: JohannesHoppe

.claude/settings.local.json

@@ -9,7 +9,12 @@
       "Bash(npm install:*)",
       "Bash(npm run compile:*)",
       "WebFetch(domain:buehler.github.io)",
-      "Bash(git log:*)"
+      "Bash(git log:*)",
+      "Bash(git rev-parse:*)",
+      "Bash(mkdir:*)",
+      "Bash(npm run compile-tests:*)",
+      "Bash(npm test)",
+      "WebFetch(domain:code.visualstudio.com)"
     ],
     "deny": [],
     "ask": []

.github/workflows/test.yml

@@ -0,0 +1,37 @@
+name: Test Mini TypeScript Hero
+
+on:
+  push:
+    branches: [main, master, second-try]
+  pull_request:
+    branches: [main, master]
+
+jobs:
+  test:
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '18.x'
+
+      - name: Install dependencies
+        run: npm install
+        working-directory: ./mini-typescript-hero
+
+      - name: Run tests (Linux with xvfb)
+        if: runner.os == 'Linux'
+        run: xvfb-run -a npm test
+        working-directory: ./mini-typescript-hero
+
+      - name: Run tests (macOS/Windows)
+        if: runner.os != 'Linux'
+        run: npm test
+        working-directory: ./mini-typescript-hero

mini-typescript-hero/dist/extension.js

@@ -240696,7 +240696,22 @@ var ImportManager = class {
         continue;
       }
       const parent = identifier.getParent();
-      if (import_ts_morph.Node.isClassDeclaration(parent) || import_ts_morph.Node.isInterfaceDeclaration(parent) || import_ts_morph.Node.isTypeAliasDeclaration(parent) || import_ts_morph.Node.isFunctionDeclaration(parent) || import_ts_morph.Node.isEnumDeclaration(parent) || import_ts_morph.Node.isVariableDeclaration(parent)) {
+      if (import_ts_morph.Node.isClassDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (import_ts_morph.Node.isInterfaceDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (import_ts_morph.Node.isTypeAliasDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (import_ts_morph.Node.isFunctionDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (import_ts_morph.Node.isEnumDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (import_ts_morph.Node.isVariableDeclaration(parent) && identifier === parent.getNameNode()) {
         continue;
       }
       if (localDeclarations.has(identifierText)) {
@@ -240800,11 +240815,13 @@ var ImportManager = class {
     );
     edits.push(import_vscode2.TextEdit.delete(range));
     const importLines = [];
+    const useSorting = !this.config.disableImportsSorting(this.document.uri);
     for (const group of importGroups) {
       if (group.imports.length === 0) {
         continue;
       }
-      const groupLines = group.sortedImports.map((imp) => this.generateImportStatement(imp));
+      const importsToUse = useSorting ? group.sortedImports : group.imports;
+      const groupLines = importsToUse.map((imp) => this.generateImportStatement(imp));
       importLines.push(...groupLines);
       importLines.push("");
     }

mini-typescript-hero/dist/extension.js.map

@@ -172,17 +172,24 @@ export class ImportManager {
         continue;
       }
 
-      // Skip if this identifier IS the declaration site itself
+      // Skip if this identifier IS the name being declared (not usages in the declaration)
       const parent = identifier.getParent();
-      if (
-        Node.isClassDeclaration(parent) ||
-        Node.isInterfaceDeclaration(parent) ||
-        Node.isTypeAliasDeclaration(parent) ||
-        Node.isFunctionDeclaration(parent) ||
-        Node.isEnumDeclaration(parent) ||
-        Node.isVariableDeclaration(parent)
-      ) {
-        // This is the declaration site, skip it
+      if (Node.isClassDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (Node.isInterfaceDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (Node.isTypeAliasDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (Node.isFunctionDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (Node.isEnumDeclaration(parent) && identifier === parent.getNameNode()) {
+        continue;
+      }
+      if (Node.isVariableDeclaration(parent) && identifier === parent.getNameNode()) {
         continue;
       }
 
@@ -333,13 +340,16 @@ export class ImportManager {
 
     // Generate new import text
     const importLines: string[] = [];
+    const useSorting = !this.config.disableImportsSorting(this.document.uri);
 
     for (const group of importGroups) {
       if (group.imports.length === 0) {
         continue;
       }
 
-      const groupLines = group.sortedImports.map(imp => this.generateImportStatement(imp));
+      // Use sortedImports only if sorting is enabled
+      const importsToUse = useSorting ? group.sortedImports : group.imports;
+      const groupLines = importsToUse.map(imp => this.generateImportStatement(imp));
       importLines.push(...groupLines);
 
       // Add blank line between groups