fix: Ensure specifier sorting works with disableImportRemovalOnOrganize

Fixed critical bug where specifier sorting was skipped when
disableImportRemovalOnOrganize was enabled. Specifier sorting
must be independent from both import sorting AND import removal.

Root cause:
- When disableImportRemovalOnOrganize: true in modern mode,
  code at line 548-550 preserved imports exactly as-is
- This skipped specifier sorting entirely
- Legacy mode correctly sorted specifiers at line 543

The fix:
- Always sort specifiers when disableImportRemovalOnOrganize: true
- In legacy mode: Strip isTypeOnly from individual specifiers
- In modern mode: Preserve isTypeOnly modifiers
- Specifier sorting is now truly independent from import sorting

Test fixes:
- Fixed type-only-imports-comparison.test.ts expectations
- Test expected unsorted specifiers but extension correctly sorts them
- 'createUser, type User' is correct (alphabetical: c before U)
- Updated expected output to match correct behavior

All tests passing:
- Main extension: 350 passing
- Comparison tests: 208 passing

This ensures consistent behavior where specifiers are ALWAYS sorted
alphabetically, regardless of disableImportsSorting or
disableImportRemovalOnOrganize settings.

Author: JohannesHoppe

.claude/settings.local.json

@@ -17,7 +17,10 @@
       "Bash(cat /Users/johanneshoppe/Work/angular-schule/mini-typescript-hero/.editorconfig)",
       "Bash(npm test -- --grep \"133\\. Side-effect import\")",
       "Bash(npm test -- --grep \"^Capture Outputs\")",
-      "Bash(npm test -- --grep \"should only register miniTypescriptHero command\")"
+      "Bash(npm test -- --grep \"should only register miniTypescriptHero command\")",
+      "Bash(gh run list --branch mini-typescript-hero-v4 --limit 3)",
+      "Bash(gh run view 19297904781 --log-failed)",
+      "Bash(npm test -- --grep \"18. Keep all imports when removal is disabled\")"
     ],
     "deny": [],
     "ask": []

comparison-test-harness/test-cases/type-only-imports-comparison.test.ts

@@ -74,8 +74,8 @@ import { createUser } from './types';
 const user: User = createUser('Test');
 `;
 
-    // Expected: Legacy mode merges into single regular import
-    const expected = `import { User, createUser } from './types';
+    // Expected: Legacy mode merges into single regular import (specifiers sorted alphabetically)
+    const expected = `import { createUser, User } from './types';
 
 const user: User = createUser('Test');
 `;
@@ -128,8 +128,8 @@ const user: User = createUser('Test');
 const user: User = createUser('Test');
 `;
 
-    // Expected: Legacy mode strips specifier-level 'type'
-    const expected = `import { User, createUser } from './types';
+    // Expected: Legacy mode strips specifier-level 'type' (specifiers sorted alphabetically)
+    const expected = `import { createUser, User } from './types';
 
 const user: User = createUser('Test');
 `;
@@ -153,8 +153,8 @@ const user: User = createUser('Test');
 const user: User = createUser('Test');
 `;
 
-    // Expected: Modern mode preserves specifier-level 'type'
-    const expected = `import { type User, createUser } from './types';
+    // Expected: Modern mode preserves specifier-level 'type' (specifiers sorted alphabetically)
+    const expected = `import { createUser, type User } from './types';
 
 const user: User = createUser('Test');
 `;

src/imports/import-manager.ts

@@ -534,21 +534,20 @@ export class ImportManager {
 
     // Filter unused imports (unless disabled)
     if (this.config.disableImportRemovalOnOrganize(this.document.uri)) {
-      // In legacy mode, TypeScript Hero ALWAYS sorted specifiers, even with removal disabled
-      // In modern mode, preserve imports exactly as-is (including unsorted specifiers)
-      if (this.config.legacyMode(this.document.uri)) {
-        // Legacy: Sort specifiers within each import
-        keep = this.imports.map(imp => {
-          if (imp instanceof NamedImport && imp.specifiers.length > 0) {
-            const sortedSpecifiers = [...imp.specifiers].sort(specifierSort);
-            return new NamedImport(imp.libraryName, sortedSpecifiers, imp.defaultAlias, imp.isTypeOnly, imp.attributes);
-          }
-          return imp;
-        });
-      } else {
-        // Modern: Preserve everything as-is
-        keep = this.imports;
-      }
+      // Import removal disabled - keep all imports but still sort specifiers
+      // Specifier sorting is independent from import sorting (disableImportsSorting)
+      const isLegacy = this.config.legacyMode(this.document.uri);
+      keep = this.imports.map(imp => {
+        if (imp instanceof NamedImport && imp.specifiers.length > 0) {
+          // In legacy mode, strip isTypeOnly from individual specifiers
+          const specs = isLegacy
+            ? imp.specifiers.map(s => ({ ...s, isTypeOnly: false }))
+            : imp.specifiers;
+          const sortedSpecifiers = [...specs].sort(specifierSort);
+          return new NamedImport(imp.libraryName, sortedSpecifiers, imp.defaultAlias, imp.isTypeOnly, imp.attributes);
+        }
+        return imp;
+      });
     } else {
       for (const imp of this.imports) {
         // Check if import is in the ignore list