chore: Add EditorConfig and enhance ESLint rules for code quality

Implements stricter code quality controls to prevent common issues
from being committed to the codebase. This includes both editor
configuration standardization and enhanced linting rules.

Key changes:
- Added .editorconfig with Angular defaults for consistent formatting
  across all editors (VS Code, WebStorm, etc.)
- Enhanced ESLint configuration with three new ERROR-level rules:
  * no-console: Prevents accidental console.log statements in production
  * no-debugger: Prevents committed debugger statements
  * @typescript-eslint/no-explicit-any: Enforces proper TypeScript typing
- Fixed all 'any' types in production code:
  * import-manager.ts: Replaced 'any' with proper ts-morph types
    (ImportDeclaration, ImportEqualsDeclaration, ExportDeclaration)
  * Test files: Documented legitimate 'any' usage in mocks with
    eslint-disable comments (for test flexibility)
- Removed redundant ci.yml workflow (test.yml already exists and is
  comprehensive)

The ESLint rules are set to ERROR (not warning) to ensure CI fails on
violations. The linter already runs twice in existing CI via the pretest
hook (once in compile, once directly), so these rules will automatically
enforce on all pushes and PRs.

All 259 tests passing. TypeScript compilation clean. ESLint clean.

Related to project audit findings and preparation for 4.0.0 release.

Author: JohannesHoppe

.claude/settings.local.json

@@ -30,7 +30,10 @@
       "SlashCommand(/git-quick)",
       "Read(///**)",
       "Bash(gh run view 18709470348 --log)",
-      "WebFetch(domain:ts-morph.com)"
+      "WebFetch(domain:ts-morph.com)",
+      "Bash(npm outdated)",
+      "Bash(npm run check-types)",
+      "Bash(npm run lint)"
     ],
     "deny": [],
     "ask": []

.editorconfig

@@ -0,0 +1,28 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.ts]
+quote_type = single
+
+[*.md]
+max_line_length = off
+trim_trailing_whitespace = false
+
+[*.yml]
+indent_size = 2
+
+[*.sh]
+end_of_line = lf
+
+[*.{json,eslintrc}]
+indent_size = 2

CLAUDE_TODO.md

@@ -4322,3 +4322,193 @@ Total:                    370 tests, 367 passing, 0 warnings
 - **Comparison harness**: 179 passing (includes 17 new Additional Coverage tests)
 - **Total**: 438 tests passing ✅
 
+
+---
+
+## Session: 2025-10-29 - Code Quality Audit and Improvements
+
+### 1. Current Work Status
+
+#### ✅ Completed Tasks:
+1. **Comprehensive Project Audit** - Conducted full codebase audit covering:
+   - Source code quality (TypeScript, architecture, patterns)
+   - Test coverage and quality (259 tests passing)
+   - Configuration files and build setup
+   - Documentation accuracy
+   - Dependency freshness
+   - Error handling patterns
+
+2. **Added `.editorconfig`** - Created EditorConfig file with Angular defaults:
+   - UTF-8 charset, 2-space indentation, LF line endings
+   - Trim trailing whitespace, insert final newline
+   - Special rules for TypeScript, Markdown, YAML, JSON
+
+3. **Enhanced ESLint Configuration** - Added strict error-level rules:
+   - `"no-console": "error"` - Prevents accidental console.log statements
+   - `"no-debugger": "error"` - Prevents committed debugger statements
+   - `"@typescript-eslint/no-explicit-any": "error"` - Enforces proper typing
+
+4. **Fixed All `any` Types in Production Code**:
+   - `src/imports/import-manager.ts`:
+     - Fixed `extractImportAttributes(importDecl: ImportDeclaration)` - was `any`
+     - Fixed `allImports` array type: `Array<ImportDeclaration | ImportEqualsDeclaration | ExportDeclaration>` - was `as any[]`
+     - Added proper type imports from `ts-morph`
+   - Test files: Documented legitimate `any` usage in mocks with `eslint-disable` comments
+
+5. **Corrected Redundant Work** - Discovered existing CI/CD workflow:
+   - Removed redundant `ci.yml` that was mistakenly created
+   - Existing `test.yml` already runs linter via `npm test` → `pretest` hook
+   - Linter runs TWICE in CI: once in compile, once directly
+
+#### ❌ In-Progress Tasks:
+None - all tasks completed.
+
+#### 🚫 Blocked Items:
+None.
+
+---
+
+### 2. Technical Context
+
+#### Files Modified:
+1. **`.editorconfig`** (NEW)
+   - Created with Angular defaults for consistent formatting
+
+2. **`eslint.config.mjs`**
+   - Added three new error-level rules: `no-console`, `no-debugger`, `@typescript-eslint/no-explicit-any`
+
+3. **`src/imports/import-manager.ts`**
+   - Line 1: Added `ImportDeclaration`, `ImportEqualsDeclaration`, `ExportDeclaration` to imports
+   - Line 75: Fixed parameter type from `any` to `ImportDeclaration`
+   - Lines 700-712: Fixed array type casting from `as any[]` to proper union type
+
+4. **Test Files (5 files)** - Added `eslint-disable` comments for legitimate mock `any` usage:
+   - `src/test/import-manager.test.ts`
+   - `src/test/import-manager.edge-cases-audit.test.ts`
+   - `src/test/import-manager.edge-cases.test.ts`
+   - `src/test/import-organizer.test.ts`
+   - `src/test/import-manager.blank-lines.test.ts`
+   - `src/test/manifest-validation.test.ts`
+   - `src/test/configuration/settings-migration.test.ts`
+
+5. **`.github/workflows/ci.yml`** (CREATED THEN DELETED)
+   - Mistakenly created duplicate workflow
+   - Deleted after discovering existing `test.yml`
+
+#### Files Created:
+- `.editorconfig` (permanent)
+- `.github/workflows/ci.yml` (temporary - already deleted)
+
+#### Files Deleted:
+- `.github/workflows/ci.yml` (redundant duplicate)
+
+---
+
+### 3. Important Decisions
+
+#### Architecture Choices:
+1. **`any` Type Strategy**:
+   - Production code: Zero tolerance - all `any` must have proper types
+   - Test mocks: Allowed with explicit `eslint-disable` comments
+   - Rationale: Test mocks legitimately need `any` for flexibility, but should be documented
+
+2. **EditorConfig Standards**:
+   - Adopted Angular's standard configuration
+   - Ensures consistency across IDEs (VS Code, WebStorm, etc.)
+
+3. **ESLint Strictness**:
+   - Made `no-console`, `no-debugger`, `no-explicit-any` ERROR level (not warnings)
+   - Rationale: These should fail CI, not just warn
+
+#### Open Questions:
+None - all decisions finalized.
+
+---
+
+### 4. Next Steps
+
+#### Immediate TODO:
+1. **Update Dependencies** (from audit findings):
+   ```bash
+   npm update
+   ```
+   - `@types/node`: 22.18.8 → 24.9.1 (2 major versions behind)
+   - `@types/vscode`: 1.104.0 → 1.105.0
+   - `@typescript-eslint/*`: 8.45.0 → 8.46.2
+   - `esbuild`, `eslint`, `ts-morph`: minor updates available
+
+2. **Clean up CLAUDE_TODO.md** (163 KB file):
+   - Archive old completed session logs
+   - Keep only recent/relevant context
+   - Consider creating `CLAUDE_TODO_ARCHIVE.md` for historical sessions
+
+3. **Decide on Version Number**:
+   - Currently: `4.0.0-rc.0` (Release Candidate)
+   - Decision: Ready for `4.0.0` release? Or document RC blockers?
+
+#### Testing Needed:
+✅ All testing complete:
+- TypeScript compilation: PASS
+- ESLint: PASS (0 errors, 0 warnings)
+- Build: PASS (esbuild successful)
+- Tests: PASS (259/259 passing in 16s)
+
+#### Documentation Updates:
+None needed - all documentation accurate.
+
+---
+
+### 5. Audit Findings Summary
+
+#### 🟢 STRENGTHS (What's Excellent):
+- Clean TypeScript with zero type errors
+- Comprehensive test coverage (259 tests)
+- Excellent documentation (CLAUDE.md, README.md)
+- Modern architecture with proper separation of concerns
+- Real VSCode API usage in tests (no brittle mocks)
+- Existing CI/CD on 3 platforms
+
+#### 🟡 MEDIUM PRIORITY (Recommended):
+- 8 outdated dependencies (security & compatibility)
+- Large CLAUDE_TODO.md file (163 KB - needs cleanup)
+- Version still marked as RC (decide on 4.0.0 release)
+
+#### 🟢 LOW PRIORITY (Nice-to-have):
+- TypeScript target could be ES2023/ES2024 (currently ES2022)
+- `.DS_Store` might be in git (check gitignore)
+
+#### Overall Assessment: **Grade A-** (Excellent)
+Project is production-ready. Only dependency updates are truly necessary before release.
+
+---
+
+### 6. Verification Results
+
+```bash
+✅ npm run check-types: PASS (0 errors)
+✅ npm run lint: PASS (0 errors, 0 warnings)
+✅ npm run compile: PASS (build successful)
+✅ npm test: PASS (259/259 tests passing in 16s)
+```
+
+---
+
+### 7. CI/CD Status
+
+**Existing Workflow**: `.github/workflows/test.yml`
+- ✅ Runs on: Ubuntu, macOS, Windows
+- ✅ Node version: 18.x
+- ✅ Tests: Main extension tests + comparison-test-harness
+- ✅ Linter: Runs TWICE (via pretest hook)
+  - Once in `npm run compile` (check-types → lint → esbuild)
+  - Once directly in `pretest` hook
+
+**Linter Execution Points**:
+| Command | Linter? | Type Check? | Build? | Tests? |
+|---------|---------|-------------|--------|--------|
+| `npm run lint` | ✅ Once | ❌ | ❌ | ❌ |
+| `npm run compile` | ✅ Once | ✅ | ✅ | ❌ |
+| `npm test` | ✅ **Twice** | ✅ | ✅ | ✅ |
+
+All new ESLint rules (`no-console`, `no-debugger`, `no-explicit-any`) now enforce in CI automatically.
+

eslint.config.mjs

@@ -19,10 +19,13 @@ export default [{
             selector: "import",
             format: ["camelCase", "PascalCase"],
         }],
+        "@typescript-eslint/no-explicit-any": "error",
 
         curly: "warn",
         eqeqeq: "warn",
         "no-throw-literal": "warn",
         semi: "warn",
+        "no-console": "error",
+        "no-debugger": "error",
     },
 }];

src/imports/import-manager.ts

@@ -1,4 +1,4 @@
-import { Project, SourceFile, Node, SyntaxKind } from 'ts-morph';
+import { Project, SourceFile, Node, SyntaxKind, ImportDeclaration, ImportEqualsDeclaration, ExportDeclaration } from 'ts-morph';
 import { EndOfLine, Position, Range, TextDocument, TextEdit } from 'vscode';
 
 import { ImportsConfig } from '../configuration';
@@ -72,7 +72,7 @@ export class ImportManager {
    * Extract import attributes/assertions from an import declaration.
    * Returns the raw text of the attributes (e.g., "assert { type: 'json' }")
    */
-  private extractImportAttributes(importDecl: any): string | undefined {
+  private extractImportAttributes(importDecl: ImportDeclaration): string | undefined {
     try {
       // Get the full text of the import declaration
       const fullText = importDecl.getText();
@@ -698,13 +698,18 @@ export class ImportManager {
     // Get the range of all import declarations (both modern and old-style)
     const importDeclarations = this.sourceFile.getImportDeclarations();
     const importEquals = this.sourceFile.getStatements()
-      .filter(stmt => Node.isImportEqualsDeclaration(stmt));
+      .filter(stmt => Node.isImportEqualsDeclaration(stmt)) as ImportEqualsDeclaration[];
 
     // Also include re-export declarations in the range (they'll be moved after imports)
     const exportDeclarations = this.sourceFile.getExportDeclarations()
       .filter(exportDecl => exportDecl.getModuleSpecifier() !== undefined);
 
-    const allImports = [...importDeclarations, ...importEquals as any[], ...exportDeclarations as any[]];
+    // Combine all declaration types - they all have getStart() and getStartLineNumber() methods
+    const allImports: Array<ImportDeclaration | ImportEqualsDeclaration | ExportDeclaration> = [
+      ...importDeclarations,
+      ...importEquals,
+      ...exportDeclarations
+    ];
 
     if (allImports.length === 0) {
       return edits;

src/test/configuration/settings-migration.test.ts

@@ -37,19 +37,27 @@ suite('Settings Migration Tests', () => {
       },
       subscriptions: [],
       extensionPath: '',
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       extensionUri: {} as any,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       environmentVariableCollection: {} as any,
       extensionMode: 3, // ExtensionMode.Production
       storageUri: undefined,
       storagePath: undefined,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       globalStorageUri: {} as any,
       globalStoragePath: '',
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       logUri: {} as any,
       logPath: '',
       asAbsolutePath: (relativePath: string) => relativePath,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       workspaceState: {} as any,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       secrets: {} as any,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       extension: {} as any,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       languageModelAccessInformation: {} as any,
     };
   });

src/test/import-manager.blank-lines.test.ts

@@ -17,8 +17,10 @@ import { createTempDocument, deleteTempDocument, applyEditsToDocument } from './
 
 // Mock config for testing
 class MockImportsConfig extends ImportsConfig {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private overrides: Map<string, any> = new Map();
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   override(key: string, value: any): void {
     this.overrides.set(key, value);
   }

src/test/import-manager.edge-cases-audit.test.ts

@@ -16,8 +16,10 @@ import { createTempDocument, deleteTempDocument, applyEditsToDocument } from './
  * Extends ImportsConfig to allow setting test values.
  */
 class MockImportsConfig extends ImportsConfig {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private mockConfig: Map<string, any> = new Map();
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   setConfig(key: string, value: any): void {
     this.mockConfig.set(key, value);
   }
@@ -282,6 +284,7 @@ const x = A + Z;
     try {
       const config = new ImportsConfig();
       // Mock multiLineTrailingComma: false
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       (config as any).mockConfig = new Map([['multiLineTrailingComma', false]]);
       const manager = new ImportManager(doc, config);
       const edits = manager.organizeImports();
@@ -380,6 +383,7 @@ const x = A + B;
     try {
       const config = new ImportsConfig();
       // Mock removeTrailingIndex: true
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       (config as any).mockConfig = new Map([['removeTrailingIndex', true]]);
       const manager = new ImportManager(doc, config);
       const edits = manager.organizeImports();

src/test/import-manager.edge-cases.test.ts

@@ -22,8 +22,10 @@ import { createTempDocument, deleteTempDocument, applyEditsToDocument } from './
  * Mock configuration for testing.
  */
 class MockImportsConfig extends ImportsConfig {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private mockConfig: Map<string, any> = new Map();
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   setConfig(key: string, value: any): void {
     this.mockConfig.set(key, value);
   }

src/test/import-manager.test.ts

@@ -87,12 +87,15 @@ import { createTempDocument, deleteTempDocument, applyEditsToDocument } from './
  * - Tests can verify different configuration combinations
  */
 class MockImportsConfig extends ImportsConfig {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private mockConfig: Map<string, any> = new Map();
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   setConfig(key: string, value: any): void {
     this.mockConfig.set(key, value);
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   override(key: string, value: any): void {
     this.mockConfig.set(key, value);
   }
@@ -154,6 +157,7 @@ class MockImportsConfig extends ImportsConfig {
     let importGroups: ImportGroup[] = [];
 
     try {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       importGroups = groupSettings.map((setting: any) => ImportGroupSettingParser.parseSetting(setting));
     } catch (e) {
       // Fall back to default on invalid config (same as real ImportsConfig)