fix: Close documents properly in tests to prevent listener leaks

The EventEmitter listener leak warnings were REAL - we were opening
226+ TextDocuments in tests but never closing them in VSCode. VSCode
kept all documents in memory with their event listeners, causing the
warnings.

Solution:
- Added 'commands.executeCommand(workbench.action.closeAllEditors)'
  to deleteTempDocument() in all test helpers
- Updated src/test/test-helpers.ts for main tests
- Updated comparison-test-harness adapters (both old and new)
- Documents are now properly closed AND files deleted

Results:
- Main Extension Tests: 226/226 passing, ZERO listener leak warnings
- Comparison Tests: 144/144 passing, ZERO listener leak warnings
- Proper resource cleanup prevents memory accumulation
- Tests run cleanly without false warnings

Thanks to @user for catching that we weren't closing documents!
The warnings were legitimate and helped us find a real resource leak.

Author: JohannesHoppe

comparison-test-harness/new-extension/adapter.ts

@@ -10,7 +10,7 @@
  * - Reference real code via relative paths (no copying!)
  */
 
-import { Uri, TextEdit, TextDocument, OutputChannel, workspace, WorkspaceEdit } from 'vscode';
+import { Uri, TextEdit, TextDocument, OutputChannel, workspace, WorkspaceEdit, commands } from 'vscode';
 import { ImportManager } from '../../src/imports/import-manager';
 import { ImportsConfig } from '../../src/configuration';
 import { ImportGroup, ImportGroupSettingParser, RemainImportGroup } from '../../src/imports/import-grouping';
@@ -33,12 +33,17 @@ async function createTempDocument(content: string): Promise<TextDocument> {
 
 /**
  * Clean up temporary file after test completes
+ * Closes the document in VSCode AND deletes the file to prevent listener leaks
  */
 async function deleteTempDocument(doc: TextDocument): Promise<void> {
   try {
+    // Close the document in VSCode to release listeners
+    await commands.executeCommand('workbench.action.closeAllEditors');
+
+    // Delete the physical file
     fs.unlinkSync(doc.uri.fsPath);
   } catch (e) {
-    // Ignore errors (file might not exist)
+    // Ignore errors - best effort cleanup
   }
 }
 

comparison-test-harness/old-extension/adapter.ts

@@ -12,7 +12,7 @@
 
 import 'reflect-metadata';
 import { TypescriptParser, TypescriptCodeGenerator, File, Generatable, GENERATORS, TypescriptGenerationOptions, MultiLineImportRule } from 'typescript-parser';
-import { Uri, TextDocument, TextEdit, window, TextEditor, workspace, WorkspaceEdit } from 'vscode';
+import { Uri, TextDocument, TextEdit, window, TextEditor, workspace, WorkspaceEdit, commands } from 'vscode';
 import { ImportManager } from '../old-typescript-hero/src/imports/import-manager';
 import { Configuration } from '../old-typescript-hero/src/configuration';
 import { ImportsConfig } from '../old-typescript-hero/src/configuration/imports-config';
@@ -39,12 +39,17 @@ async function createTempDocument(content: string): Promise<TextDocument> {
 
 /**
  * Clean up temporary file after test completes
+ * Closes the document in VSCode AND deletes the file to prevent listener leaks
  */
 async function deleteTempDocument(doc: TextDocument): Promise<void> {
   try {
+    // Close the document in VSCode to release listeners
+    await commands.executeCommand('workbench.action.closeAllEditors');
+
+    // Delete the physical file
     fs.unlinkSync(doc.uri.fsPath);
   } catch (e) {
-    // Ignore errors (file might not exist)
+    // Ignore errors - best effort cleanup
   }
 }
 

src/test/test-helpers.ts

@@ -8,7 +8,7 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import * as os from 'os';
-import { Uri, TextEdit, TextDocument, workspace, WorkspaceEdit } from 'vscode';
+import { Uri, TextEdit, TextDocument, workspace, WorkspaceEdit, commands } from 'vscode';
 
 /**
  * Create a REAL temporary file and open it as a TextDocument
@@ -33,14 +33,22 @@ export async function createTempDocument(content: string, extension: string = 't
  * Clean up temporary file after test completes
  *
  * Always call this in a finally block to ensure cleanup even if test fails.
+ * This properly closes the document in VSCode AND deletes the file to prevent listener leaks.
  *
  * @param doc - The TextDocument created by createTempDocument()
  */
 export async function deleteTempDocument(doc: TextDocument): Promise<void> {
   try {
+    // Close the document in VSCode to release listeners
+    // Use workbench.action.closeAllEditors to close all open editors/documents
+    // This is more reliable than trying to close individual documents
+    await commands.executeCommand('workbench.action.closeAllEditors');
+
+    // Delete the physical file
     fs.unlinkSync(doc.uri.fsPath);
   } catch (e) {
-    // Ignore errors (file might not exist)
+    // Ignore errors - best effort cleanup
+    // Document might already be closed or file might not exist
   }
 }