refactor: add tslint-sonarts and a lot of tslint rules

This should clean up the code a bit.

Note: at first I added the no-useless-cast rule, but after getting frustrated
with it (as it has many false positive), I decided to remove the rule but some
useless casts were removed so I let those in the PR.

Author: hansl

package-lock.json

@@ -130,6 +130,7 @@
     "tree-kill": "^1.2.0",
     "ts-node": "^5.0.0",
     "tslint": "^5.9.1",
+    "tslint-sonarts": "^1.7.0",
     "tsutils": "~2.22.2",
     "typescript": "~2.7.2",
     "uglifyjs-webpack-plugin": "^1.2.5",

package.json

@@ -22,8 +22,6 @@ export default class VersionCommand extends Command {
   public readonly options: Option[] = [];
 
   public run() {
-    let angularCoreVersion = '';
-    const angularSameAsCore: string[] = [];
     const pkg = require(path.resolve(__dirname, '..', 'package.json'));
     let projPkg;
     try {
@@ -95,6 +93,8 @@ export default class VersionCommand extends Command {
 
       ngCliVersion = `local (v${pkg.version}, branch: ${gitBranch})`;
     }
+    let angularCoreVersion = '';
+    const angularSameAsCore: string[] = [];
 
     if (projPkg) {
       // Filter all angular versions that are the same as core.
@@ -107,6 +107,9 @@ export default class VersionCommand extends Command {
             delete versions[angularPackage];
           }
         }
+
+        // Make sure we list them in alphabetical order.
+        angularSameAsCore.sort();
       }
     }
 
@@ -128,7 +131,7 @@ export default class VersionCommand extends Command {
       Node: ${process.versions.node}
       OS: ${process.platform} ${process.arch}
       Angular: ${angularCoreVersion}
-      ... ${angularSameAsCore.sort().reduce<string[]>((acc, name) => {
+      ... ${angularSameAsCore.reduce<string[]>((acc, name) => {
         // Perform a simple word wrap around 60.
         if (acc.length == 0) {
           return [name];

packages/angular/cli/commands/version.ts

@@ -15,7 +15,7 @@ export type NpmInstall = (packageName: string,
                           logger: logging.Logger,
                           packageManager: string,
                           projectRoot: string,
-                          save?: boolean) => void;
+                          save?: boolean) => Promise<void>;
 
 export default async function (packageName: string,
                                logger: logging.Logger,

packages/angular/cli/tasks/npm-install.ts

@@ -119,7 +119,7 @@ export function getWorkspaceRaw(
     throw new Error('Invalid JSON');
   }
 
-  return [ast as JsonAstObject, configPath];
+  return [ast, configPath];
 }
 
 export function validateWorkspace(json: JsonObject) {

packages/angular/cli/utilities/config.ts

@@ -34,17 +34,15 @@ export class TestProjectHost extends NodeJsSyncHost {
       throw new Error('TestProjectHost must be initialized before being used.');
     }
 
-    // tslint:disable-next-line:non-null-operator
-    return this._currentRoot!;
+    return this._currentRoot;
   }
 
   scopedSync(): virtualFs.SyncDelegateHost<Stats> {
     if (this._currentRoot === null || this._scopedSyncHost === null) {
       throw new Error('TestProjectHost must be initialized before being used.');
     }
 
-    // tslint:disable-next-line:non-null-operator
-    return this._scopedSyncHost!;
+    return this._scopedSyncHost;
   }
 
   initialize(): Observable<void> {
@@ -100,7 +98,7 @@ export class TestProjectHost extends NodeJsSyncHost {
   }
 
   writeMultipleFiles(files: { [path: string]: string | ArrayBufferLike | Buffer }): void {
-    Object.keys(files).map(fileName => {
+    Object.keys(files).forEach(fileName => {
       let content = files[fileName];
       if (typeof content == 'string') {
         content = virtualFs.stringToFileBuffer(content);

packages/angular_devkit/architect/testing/test-project-host.ts

@@ -290,13 +290,13 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
     let sslKey: string | undefined = undefined;
     let sslCert: string | undefined = undefined;
     if (options.sslKey) {
-      const keyPath = path.resolve(root, options.sslKey as string);
+      const keyPath = path.resolve(root, options.sslKey);
       if (existsSync(keyPath)) {
         sslKey = readFileSync(keyPath, 'utf-8');
       }
     }
     if (options.sslCert) {
-      const certPath = path.resolve(root, options.sslCert as string);
+      const certPath = path.resolve(root, options.sslCert);
       if (existsSync(certPath)) {
         sslCert = readFileSync(certPath, 'utf-8');
       }

packages/angular_devkit/build_angular/src/dev-server/index.ts

@@ -83,7 +83,7 @@ export class KarmaBuilder implements Builder<KarmaBuilderSchema> {
 
         // TODO: inside the configs, always use the project root and not the workspace root.
         // Until then we pretend the app root is relative (``) but the same as `projectRoot`.
-        (karmaOptions.buildWebpack.options as any).root = ''; // tslint:disable-line:no-any
+        karmaOptions.buildWebpack.options.root = '';
 
         // Assign additional karmaConfig options to the local ngapp config
         karmaOptions.configFile = karmaConfig;
@@ -112,7 +112,7 @@ export class KarmaBuilder implements Builder<KarmaBuilderSchema> {
   ) {
     let wco: WebpackConfigOptions;
 
-    const tsConfigPath = getSystemPath(resolve(root, normalize(options.tsConfig as string)));
+    const tsConfigPath = getSystemPath(resolve(root, normalize(options.tsConfig)));
     const tsConfig = readTsconfig(tsConfigPath);
 
     const projectTs = requireProjectModule(getSystemPath(projectRoot), 'typescript') as typeof ts;

packages/angular_devkit/build_angular/src/karma/index.ts

@@ -106,8 +106,8 @@ export class ServerBuilder implements Builder<BuildWebpackServerSchema> {
 
     if (wco.buildOptions.main || wco.buildOptions.polyfills) {
       const typescriptConfigPartial = wco.buildOptions.aot
-        ? getAotConfig(wco, host as virtualFs.Host<Stats>)
-        : getNonAotConfig(wco, host as virtualFs.Host<Stats>);
+        ? getAotConfig(wco, host)
+        : getNonAotConfig(wco, host);
       webpackConfigs.push(typescriptConfigPartial);
     }
 

packages/angular_devkit/build_angular/src/server/index.ts

@@ -5,6 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+// tslint:disable:no-big-function
 
 import { DefaultTimeout, TestLogger, runTargetSpec } from '@angular-devkit/architect/testing';
 import { join, normalize, virtualFs } from '@angular-devkit/core';