refactor: add no-floating-promises lint rule to project

With fixes; new now handles the parent initialize, visitor_spec now errors on
rejection, and nothing in the writeI18nOutFile() function was async so removed
the promise there entirely.

Author: hansl

packages/angular/cli/commands/new.ts

@@ -39,24 +39,25 @@ export default class NewCommand extends SchematicCommand {
   private schematicName = 'ng-new';
 
   private initialized = false;
-  public initialize(options: any) {
+  public async initialize(options: any) {
     if (this.initialized) {
-      return Promise.resolve();
+      return;
     }
-    super.initialize(options);
+
+    await super.initialize(options);
+
     this.initialized = true;
 
     const collectionName = this.parseCollectionName(options);
 
-    return this.getOptions({
-        schematicName: this.schematicName,
-        collectionName,
-      })
-      .then((schematicOptions) => {
-        this.options = this.options.concat(schematicOptions.options);
-        const args = schematicOptions.arguments.map(arg => arg.name);
-        this.arguments = this.arguments.concat(args);
-      });
+    const schematicOptions = await this.getOptions({
+      schematicName: this.schematicName,
+      collectionName,
+    });
+
+    this.options = this.options.concat(schematicOptions.options);
+    const args = schematicOptions.arguments.map(arg => arg.name);
+    this.arguments = this.arguments.concat(args);
   }
 
   public async run(options: any) {

packages/angular_devkit/core/src/json/schema/visitor_spec.ts

@@ -14,13 +14,15 @@ function syncObs<T>(obs: Observable<T>): T {
   let value: T;
   let set = false;
 
-  obs.forEach(x => {
-    if (set) {
-      throw new Error('Multiple value.');
-    }
-    value = x;
-    set = true;
-  });
+  obs
+    .forEach(x => {
+      if (set) {
+        throw new Error('Multiple value.');
+      }
+      value = x;
+      set = true;
+    })
+    .catch(err => fail(err));
 
   if (!set) {
     throw new Error('Async observable.');

packages/ngtools/webpack/src/angular_compiler_plugin.ts

@@ -902,12 +902,10 @@ export class AngularCompilerPlugin {
   }
 
   writeI18nOutFile() {
-    function _recursiveMkDir(p: string): Promise<void> {
-      if (fs.existsSync(p)) {
-        return Promise.resolve();
-      } else {
-        return _recursiveMkDir(path.dirname(p))
-          .then(() => fs.mkdirSync(p));
+    function _recursiveMkDir(p: string) {
+      if (!fs.existsSync(p)) {
+        _recursiveMkDir(path.dirname(p));
+        fs.mkdirSync(p);
       }
     }
 
@@ -916,8 +914,8 @@ export class AngularCompilerPlugin {
       const i18nOutFilePath = path.resolve(this._basePath, this._compilerOptions.i18nOutFile);
       const i18nOutFileContent = this._compilerHost.readFile(i18nOutFilePath);
       if (i18nOutFileContent) {
-        _recursiveMkDir(path.dirname(i18nOutFilePath))
-          .then(() => fs.writeFileSync(i18nOutFilePath, i18nOutFileContent));
+        _recursiveMkDir(path.dirname(i18nOutFilePath));
+        fs.writeFileSync(i18nOutFilePath, i18nOutFileContent);
       }
     }
   }

tslint.json

@@ -9,6 +9,7 @@
     "non-null-operator": true,
     "no-global-tslint-disable": true,
     "single-eof-line": true,
+    "no-floating-promises": true,
 
 
     "no-implicit-dependencies": true,