fix(@schematics/angular): generate resolvers with a dash type separator#30032
Merged
Conversation
clydin
added
the
action: review
alan-agius4
approved these changes
Apr 4, 2025
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, can you please add a description to the new option in the schema.json?
clydin
force-pushed
the
style-guide/resolver
branch
from
c91e18f to
c4a6e5a
Compare
To align with the updated style guide, Angular v20 will generate resolvers with file extension `resolver` type prefixed with a `-` separator instead of a `.` by default. Projects will automatically use this naming convention. Projects can however opt-out by setting the `typeSeparator` option to `.` for the resolver schematic. This can be done as a default in the `angular.json` or directly on the commandline via `--type-separator=.` when executing `ng generate`. As an example, `example.resolver.ts` will now be named `example-resolver.ts`. The TypeScript declaration will continue to contain `Resolver` such as with `ExampleResolver`.
clydin
force-pushed
the
style-guide/resolver
branch
from
c4a6e5a to
055a654
Compare
alan-agius4
approved these changes
Apr 4, 2025
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the updated style guide, Angular v20 will generate resolvers with file extension
resolvertype prefixed with a-separator instead of a.by default. Projects will automatically use this naming convention. Projects can however opt-out by setting thetypeSeparatoroption to.for the resolver schematic. This can be done as a default in theangular.jsonor directly on the commandline via--type-separator=.when executingng generate. As an example,example.resolver.tswill now be namedexample-resolver.ts. The TypeScript declaration will continue to containResolversuch as withExampleResolver.