build: improve stability of windows jobs further#30238
Merged
Merged
Conversation
devversion
force-pushed
the
test-patch-win
branch
5 times, most recently
from
fc9b82d to
96b5c44
Compare
angular-robot
Bot
added
the
area: build & ci
With the recent commit to rework the convert symlink script, we addressed the high flakiness of module resolution errors due to broken/missing symlinks. Though, this commit introduces a new source of flakiness that we tried to avoid in the past— running too many WSL exe's at the same time. We fix this by reducing the batch size and adding another retry for safety. In addition, the patch branch uses an older NodeJS version where `fs.cp` seems to have issues when the source files are readonly— so we fix that by just invoking the shell's `cp` command. That one works
devversion
added
action: review
crisbeto
approved these changes
May 4, 2025
devversion
added
action: merge
Member
Author
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent commit to rework the convert symlink script, we
addressed the high flakiness of module resolution errors due to
broken/missing symlinks. Though, this commit introduces a new source of
flakiness that we tried to avoid in the past— running too many WSL exe's
at the same time. We fix this by reducing the batch size and adding
another retry for safety.
In addition, the patch branch uses an older NodeJS version where
fs.cpseems to have issues when the source files are readonly— so wefix that by just invoking the shell's
cpcommand. That one works.