refactor(@angular-devkit/build-angular): switch to tinyglobby#31131
Conversation
|
The commit message scope should be |
benmccann
changed the title
| "//:node_modules/@types/node", | ||
| "//:node_modules/fast-glob", | ||
| "//:node_modules/prettier", | ||
| ":node_modules/tinyglobby", |
There was a problem hiding this comment.
| ":node_modules/tinyglobby", | |
| "//:node_modules/tinyglobby", |
| "//:node_modules/karma", | ||
| "//:node_modules/karma-source-map-support", | ||
| "//:node_modules/semver", | ||
| ":node_modules/tinyglobby", |
There was a problem hiding this comment.
| ":node_modules/tinyglobby", | |
| "//:node_modules/tinyglobby", |
Bazel paths always start with //, only local targets can be accessed with :.
There was a problem hiding this comment.
@alan-agius4 suggested above that I should remove it: #31131 (comment)
I'm a bit confused as to whether I should have the // in one place, neither, or both
There was a problem hiding this comment.
:node_modules/tinyglobby and //: :node_modules/tinyglobby are two different targets. In this case it should not be with the// prefix. As we want to resolve the dependency from the locally defined node modules, IE: this package package.json and not defined in the workspace package.json.
benmccann
force-pushed
the
tinyglobby
branch
from
1914550 to
6a4c661
Compare
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
alan-agius4
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using a mix of
tinyglobbyandfast-glob.fast-globpulls in 17 dependenciesIssue Number: #31130
What is the new behavior?
Using only
tinyglobby, which has only 2 dependenciesDoes this PR introduce a breaking change?
Other information