Skip to content

feat(@schematics/angular): add browserMode option to jasmine-vitest schematic#31920

Merged
clydin merged 1 commit into
angular:mainfrom
jnizet:feat/avoid-migrating-to-have-class
Nov 24, 2025
Merged

feat(@schematics/angular): add browserMode option to jasmine-vitest schematic#31920
clydin merged 1 commit into
angular:mainfrom
jnizet:feat/avoid-migrating-to-have-class

Conversation

@jnizet

@jnizet jnizet commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

This option allows not migrating the toHaveClass assertion, which exists in Vitest in browser mode and thus is best left as is.

fix #31917

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31917

What is the new behavior?

A new browserMode option allows not migrating the toHaveClass assertion, which exists in Vitest in browser mode and thus is best left as is.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…chematic

This option allows not migrating the `toHaveClass` assertion, which exists in Vitest in browser mode and thus is best left as is.

fix angular#31917
@alan-agius4 alan-agius4 requested a review from clydin November 24, 2025 09:43
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 24, 2025
@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 24, 2025
@clydin clydin merged commit 36cf3af into angular:main Nov 24, 2025
39 checks passed
@clydin

clydin commented Nov 24, 2025

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add option to avoid migrating toHaveClass matcher

3 participants